Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove LocalCryptographyClient in favor of CryptographyClient local mode #18575

Closed
heaths opened this issue Feb 8, 2021 · 0 comments · Fixed by #18892
Closed

Remove LocalCryptographyClient in favor of CryptographyClient local mode #18575

heaths opened this issue Feb 8, 2021 · 0 comments · Fixed by #18892
Assignees
@heaths
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] March

Comments

@heaths
Copy link
Member

heaths commented Feb 8, 2021

Per archboard feedback and subsequent discussions, remove (or internalize) the LocalCryptographyClient class in favor of making a local-only "mode" of the existing CryptographyClient. This should be done in a constructor or language equivalent, and take only a JsonWebKey and, optionally (only if need to), a CryptographyClientOptions. For example, .NET uses the Diagnostic options for tracing.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Feb 8, 2021
@heaths heaths added this to the [2021] March milestone Feb 8, 2021
@heaths heaths self-assigned this Feb 8, 2021
@heaths heaths mentioned this issue Feb 8, 2021
Closed
7 tasks
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Feb 19, 2021
@heaths
Remove LocalCryptographyClient in favor of local-only mode for Crypto…
f2441fb 
…graphyClient

Resolves Azure#18575
@heaths heaths mentioned this issue Feb 19, 2021
Merged
heaths added a commit that referenced this issue Feb 20, 2021
@heaths
Remove LocalCryptographyClient in favor of local-only mode for Crypto…
fbfd4eb 
…graphyClient (#18892)

* Remove LocalCryptographyClient in favor of local-only mode for CryptographyClient

Resolves #18575

* Update public APIs

* Resolve PR feedback
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@heaths heaths

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] March
1 participant
@heaths