Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IReliableConcurrentQueue<T>.TryDequeue Timeout behavior description #21326

Closed
smstuebe opened this issue May 25, 2021 · 5 comments
Closed

IReliableConcurrentQueue<T>.TryDequeue Timeout behavior description #21326

smstuebe opened this issue May 25, 2021 · 5 comments
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Service Fabric

Comments

@smstuebe
Copy link

smstuebe commented May 25, 2021 •
edited
Loading

The documentations says:

If a value was dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

shouldn't it be:

If a value was >>>not<<< dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

?

Second topic
I as a reader can't understand what the exact timeout behavior is, because there is this the sentence I mentioned above, but there is also a TimeOutException. The documentation should be more explicitly about the differences and when wich case happens.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels May 25, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Service Fabric labels May 25, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 25, 2021
@ghost
Copy link

ghost commented May 25, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @QingChenmsft, @vaishnavk, @juhacket.

Issue Details

The documentations says:

If a value was dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

shouldn't it be:

If a value was >>>not<<< dequeued within the given time, return a ConditionalValue with HasValue as false, else it returns a ConditionalValue with HasValue as true and the Value as the dequeued item of Type T

?

Second topic
I as a reader can't understand what the exact timeout behavior is, because there is this the sentence I mentioned above, but there is also a TimeOutException. The documentation should be more explicitly about the differences and when wich case happens.

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Author: smstuebe
Assignees: -
Labels:

Client, Docs, Service Attention, Service Fabric, customer-reported, needs-team-attention, needs-triage, question
Milestone: -

@jsquire
Copy link
Member

jsquire commented May 25, 2021

Thank you for your feedback. Tagging and routing to the team best able to assist.

@SaurabhSharma-MSFT
Copy link
Member

@QingChenmsft, @vaishnavk, @juhacket Do you have any updates on this issue.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this issue Nov 24, 2022
@paulgmiller @wenxuan0923
@matthchr @InduSridhar
CodeGen from PR 21439 in Azure/azure-rest-api-specs
35ff67e 
Review request for Microsoft.ContainerService to add version 2022-10-02-preview (Azure#21439)

* Adds base for updating Microsoft.ContainerService from version preview/2022-09-02-preview to version 2022-10-02-preview

* Updates readme

* Updates API version in new specs and examples

* Pmiller/nodeosupgradechannel (Azure#21326)

* missed working comment

* matthew comments

* unpatched is a word

* Add MaintenanceWindow into MaintenanceConfigurationProperties (Azure#21337)

* Add MaintenanceWindow into MaintenanceConfigurationProperties

* Fx PrettierCheck

* Fix ARM ID format for samples (Azure#21402)

* Fix Swagger Model Validation for the 2022-10-02-preview dev branch of container service (Azure#21373)

* fix API version

* fix INVALID_FORMAT byte

* fix INVALID_FORMAT arm-id

* fix missing resource id

* fix LRO_RESPONSE_HEADER

* Update readmes for the 2022-10-02-preview dev branch of container service (Azure#21366)

* update readmes

* remove fleets

* Updating abort apis response to make it long running  (Azure#21362)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

Co-authored-by: InduSridhar <[email protected]>

* fix 202 location header

* fix ProvisioningState validation

* add x-ms-long-running-operation-options

* fix ResourceNameRestriction

* Fix abort location url in example (Azure#21446)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

Co-authored-by: InduSridhar <[email protected]>

* Abort api response fix (Azure#21559)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

Co-authored-by: InduSridhar <[email protected]>

* Node os upgrade desc fix (Azure#21636)

* Updating response abort abort apis

* Updating abort AP and MC examples

* Changes per CI checks

* Adding x-ms-long-running-operation-options

* Adding location header

* Fixing location url in abort examples

* Fixing headers and body for abort response

* Linter fix

* Lint fix

* Updating managedclusters.json responses

* Minor edit to node os upgrade description based on ARM review

Co-authored-by: InduSridhar <[email protected]>

Co-authored-by: Paul Miller <[email protected]>
Co-authored-by: Thalia Wang <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Co-authored-by: InduSridhar <[email protected]>
Co-authored-by: InduSridhar <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Hi @smstuebe, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

Hi @smstuebe, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 8, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. Docs needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention Workflow: This issue is responsible by Azure service team. Service Fabric
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsquire @smstuebe @SaurabhSharma-MSFT