Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnippetGenerator showing a red completion message is very misleading #22347

Closed
heaths opened this issue Jun 30, 2021 · 0 comments · Fixed by #23210 or Azure/azure-sdk-tools#1954
Closed

SnippetGenerator showing a red completion message is very misleading #22347

heaths opened this issue Jun 30, 2021 · 0 comments · Fixed by #23210 or Azure/azure-sdk-tools#1954
Labels
EngSys This issue is impacting the engineering system.

Comments

@heaths
Copy link
Member

heaths commented Jun 30, 2021

Recently, SnippetGenerator emits the following at the end:

image

This was a bit of a shock at first since red == error, but there were none. I had to verify it, which took a little extra time.

If the idea is to highlight that it's finished (not sure how that helps interactively), yellow might be better. Or show green for no errors and red if there were errors (missing snippets or unused regions).
@heaths heaths added the EngSys This issue is impacting the engineering system. label Jun 30, 2021
heaths added a commit to heaths/azure-sdk-for-net that referenced this issue Aug 9, 2021
@heaths
Do not print red success message
ed495f7 
Fixes Azure#22347
@heaths heaths mentioned this issue Aug 9, 2021
Merged
heaths added a commit that referenced this issue Aug 30, 2021
@heaths
Do not print red success message (#23210)
2214295 
Fixes #22347
heaths added a commit to heaths/azure-sdk-tools that referenced this issue Aug 30, 2021
@heaths
Do not print red success message
5f13cac 
Resolves Azure/azure-sdk-for-net#22347 and is a port of Azure/azure-sdk-for-net#23210
@heaths heaths mentioned this issue Aug 30, 2021
Merged
weshaggard pushed a commit to Azure/azure-sdk-tools that referenced this issue Aug 31, 2021
@heaths
Do not print red success message (#1954)
d5145fc 
Resolves Azure/azure-sdk-for-net#22347 and is a port of Azure/azure-sdk-for-net#23210
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
1 participant
@heaths