Updated management SDK for Azure Attestation Service to latest swagger spec with Location and Tags support #10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkostal
requested review from
AlexGhiondea,
erich-wang and
isra-fel
as code owners
isra-fel
reviewed
Mar 2, 2020
| @@ -35,5 +35,5 @@ | |||
| // You can specify all the values or you can default the Build and Revision Numbers | |||
| // by using the '*' as shown below: | |||
| // [assembly: AssemblyVersion("1.0.*")] | |||
| [assembly: AssemblyVersion("0.10.0.0")] | |||
| [assembly: AssemblyFileVersion("0.10.0.0")] | |||
| [assembly: AssemblyVersion("0.11.0.0")] | |||
There was a problem hiding this comment.
Updating assembly info of the test project is not required, as it's not published anywhere.
There was a problem hiding this comment.
Makes sense. I've inherited this code and was updating all existing 0.10.0.0 version numbers to 0.11.0.0. It's OK to leave as 0.11.0.0 right?
isra-fel
reviewed
Mar 2, 2020
There was a problem hiding this comment.
Hey @gkostal , I assume this file sdk/attestation/Microsoft.Azure.Management.Attestation/src/Generated/code-model-v1 was checked in by accident. I have deleted it.
And by the way, did you generate code by running generate.ps1 or autorest.cmd?
isra-fel
added
Mgmt
labels
isra-fel
approved these changes
Mar 2, 2020
|
Management place CI passed. Merging the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This is the update to the .NET management SDK for the Azure Attestation Service based on the swagger changes made in this PR:
Azure/azure-rest-api-specs#8478
Tests
New tests have been added, recordings have been generated and all tests are passing in playback mode.