Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regenerate EventGrid .NET SDK to reflect new swagger bug fixes for 20-04-01-preview #10974

Merged
merged 2 commits into from
Apr 7, 2020
Merged

Regenerate EventGrid .NET SDK to reflect new swagger bug fixes for 20-04-01-preview #10974

merged 2 commits into from
Apr 7, 2020

Conversation

ahamad-MS
Copy link
Contributor

@ahamad-MS ahamad-MS commented Apr 1, 2020 •
edited
Loading

Regenerate EventGrid .NET SDK to reflect new swagger bug fixes for 2020-04-01-preview.

Swagger PR: Azure/azure-rest-api-specs#8880

@ahamad-MS
Copy link
Contributor Author

@isra-fel , @erich-wang Can you please review and help merge this change? thanks

@isra-fel isra-fel self-assigned this Apr 2, 2020
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Apr 2, 2020
isra-fel
isra-fel suggested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you

  • Add a link to the swagger spec review PR in the description
  • Include the .txt file generated when you run generate.ps1(details)
  • Update AssemblyFileVersion in assemblyinfo.cs

Thanks

@ahamad-MS ahamad-MS requested a review from isra-fel April 2, 2020 17:39
@ahamad-MS
Copy link
Contributor Author

@isra-fel All comments are addressed. Can you please recheck.

thanks

isra-fel
isra-fel approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isra-fel isra-fel merged commit fef6a54 into Azure:master Apr 7, 2020
@ahamad-MS ahamad-MS deleted the master branch May 14, 2020 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees

@isra-fel isra-fel

@ahamad-MS ahamad-MS

Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahamad-MS @isra-fel