Fix mixing change log entries #11405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the mixing change log entries and enable checking of them during dev builds.
weshaggard
requested review from
AlexGhiondea,
danieljurek,
jsquire,
kinelski,
mitchdenny and
serkantkaraca
as code owners
pakrym
approved these changes
Apr 17, 2020
jsquire
reviewed
Apr 17, 2020
| @@ -1,5 +1,8 @@ | |||
| # Release History | |||
|
|
|||
| ## 4.2.1 (Unreleased) | |||
There was a problem hiding this comment.
Not sure if this is a relevant point, but the Microsoft.Azure.EventHubs series of projects are the track one client, which is owned by the service team. I don't recall whether we were applying the change log guidelines to them or not.
There was a problem hiding this comment.
They were already mostly following it so I fixed up the version property in their project and added this entry to get them updated and now our tools will help them with version bumps as well as ensuring they have change logs.
jsquire
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
LGTM, but I'd consider @serkantkaraca the authoritative voice for the changes made to the track one Event Hubs assets.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Nov 19, 2020
Swagger Correctness for Cognitive Services (Azure#11405) * Swagger Correctness * Undo changes in 2016-02-01-preview * Move location of field * change enum type to string for Sku.tier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the mixing change log entries and enable checking of them
during dev builds.
fyi @pakrym