EventHub: updated Package and added new test BYOK and Clusters #11949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
suggested changes
May 9, 2020
There was a problem hiding this comment.
Hi, we updated our folder structure quite log ago. Every project should be in /sdk. Please remove src/SDKs and everything in it.
Besides, please generate your sdk using this script sdk/eventhub/Microsoft.Azure.Management.EventHub/src/generate.ps1. It should also generate a metadata file in /eng/mgmt/mgmtmetada please also check it in.
Thanks
isra-fel
added
Mgmt
|
@isra-fel, added all swagger PRs regarding changes, added release notes and updated version. please review and let me know if any changes needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger PR Links :
Azure/azure-rest-api-specs#9207
Azure/azure-rest-api-specs#9245
Azure/azure-rest-api-specs#9321
Azure/azure-rest-api-specs#9335