initial check in for KeyVault mgmt track 2 #12039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
added
Mgmt
erich-wang
requested review from
KrzysztofCwalina
and removed request for
isra-fel
erich-wang
force-pushed
the
erich/mgmt.keyvault
branch
from
a42d224
to
488d18d
Compare
erich-wang
requested review from
chidozieononiwu,
danieljurek,
mitchdenny and
weshaggard
as code owners
erich-wang
force-pushed
the
erich/mgmt.keyvault
branch
2 times, most recently
from
db50ec9
to
3bd826c
Compare
pakrym
reviewed
May 18, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
May 18, 2020
| } | ||
| } | ||
| var provider = (await ResourceProvidersClient.GetAsync("Microsoft.KeyVault")).Value; | ||
| this.location = provider.ResourceTypes.Where( |
There was a problem hiding this comment.
LOcation is available on TestEnvironment
There was a problem hiding this comment.
Prefer to set environment variables as less as possible for recording.
There was a problem hiding this comment.
You don't need to set them manually or at all, please use the New-TestResources script with -OutFile parameter.
pakrym
reviewed
May 18, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
May 18, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
May 18, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Outdated
Show resolved
Hide resolved
pakrym
reviewed
May 18, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Outdated
Show resolved
Hide resolved
erich-wang
force-pushed
the
erich/mgmt.keyvault
branch
from
670840d
to
514b688
Compare
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
|
/azp run net - keyvault - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pakrym
reviewed
May 19, 2020
| namespace Azure.Management.KeyVault.Tests | ||
| { | ||
| [ClientTestFixture] | ||
| [NonParallelizable] |
There was a problem hiding this comment.
Do we want to keep tests non-parallelizeable?
pakrym
reviewed
May 19, 2020
sdk/keyvault/Azure.Management.KeyVault/tests/VaultOperationsTestsBase.cs
Show resolved
Hide resolved
weshaggard
reviewed
May 20, 2020
| @@ -0,0 +1,37 @@ | |||
| | |||
There was a problem hiding this comment.
@erich-wang @allenjzhang why is this project going under testcommon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of KeyVault mgmt track 2 SDK