Add message batch factory #18146
Merged
Add message batch factory #18146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
JoshLove-msft
commented
Jan 22, 2021
| @@ -0,0 +1,7 @@ | |||
| # Baselining these until the next GA as they are not actual compat issues. | |||
| CannotRemoveAttribute : Attribute 'System.ComponentModel.EditorBrowsableAttribute' exists on 'Azure.Messaging.ServiceBus.ServiceBusModelFactory.TopicProperties(System.String, System.Int64, System.Boolean, System.TimeSpan, System.TimeSpan, System.TimeSpan, System.Boolean, Azure.Messaging.ServiceBus.Administration.EntityStatus, System.Boolean)' in the contract but not the implementation. | |||
There was a problem hiding this comment.
These were needed as I removed the EditorBrowsable.Never attribute that was incorrectly added on the factory methods before.
/cc @weshaggard
jsquire
approved these changes
Jan 22, 2021
| /// | ||
| /// <returns>The <see cref="ServiceBusMessageBatch" /> instance that was created.</returns> | ||
| /// | ||
| public static ServiceBusMessageBatch ServiceBusMessageBatch(long batchSizeBytes, |
There was a problem hiding this comment.
My bad, Josh. It should have occurred to me to port this over when I did the EH version.
JoshLove-msft
requested review from
KrzysztofCwalina and
tg-msft
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly copied from #17405
Addresses #16142