Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare MR Authentication for pre-release #18613

Merged
2 commits merged into from
Feb 10, 2021
Merged

Prepare MR Authentication for pre-release #18613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c562e0
Removed nullable
Feb 9, 2021
7197824
Changed to a beta package
Feb 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sdk/mixedreality/Azure.MixedReality.Authentication/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Release History

## 1.0.0-beta.1 (2021-02-09)

- Removed nullable annotations per guidance.

## 1.0.0-preview.3 (2021-01-15)

- Updated to latest version of spec file which changes the account identifier to be a `Guid` rather than a `string`.
Expand Down
8 changes: 4 additions & 4 deletions ...Azure.MixedReality.Authentication/api/Azure.MixedReality.Authentication.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ namespace Azure.MixedReality.Authentication
public partial class MixedRealityStsClient
{
protected MixedRealityStsClient() { }
public MixedRealityStsClient(System.Guid accountId, string accountDomain, Azure.AzureKeyCredential keyCredential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions? options = null) { }
public MixedRealityStsClient(System.Guid accountId, string accountDomain, Azure.Core.TokenCredential credential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions? options = null) { }
public MixedRealityStsClient(System.Guid accountId, System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions? options = null) { }
public MixedRealityStsClient(System.Guid accountId, System.Uri endpoint, Azure.Core.TokenCredential credential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions? options = null) { }
public MixedRealityStsClient(System.Guid accountId, string accountDomain, Azure.AzureKeyCredential keyCredential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions options = null) { }
public MixedRealityStsClient(System.Guid accountId, string accountDomain, Azure.Core.TokenCredential credential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions options = null) { }
public MixedRealityStsClient(System.Guid accountId, System.Uri endpoint, Azure.AzureKeyCredential keyCredential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions options = null) { }
public MixedRealityStsClient(System.Guid accountId, System.Uri endpoint, Azure.Core.TokenCredential credential, Azure.MixedReality.Authentication.MixedRealityStsClientOptions options = null) { }
public System.Guid AccountId { get { throw null; } }
public System.Uri Endpoint { get { throw null; } }
public virtual Azure.Response<Azure.Core.AccessToken> GetToken(System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
Expand Down
4 changes: 1 addition & 3 deletions ...xedreality/Azure.MixedReality.Authentication/src/Azure.MixedReality.Authentication.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<AssemblyTitle>Microsoft Azure Mixed Reality STS Client</AssemblyTitle>
<Version>1.0.0-preview.2</Version>
<Version>1.0.0-beta.1</Version>
<PackageTags>Azure MixedReality</PackageTags>
<Copyright>© Microsoft Corporation. All rights reserved.</Copyright>
<Authors>Microsoft</Authors>
<PackageProjectUrl>https://azure.microsoft.com/topic/mixed-reality/</PackageProjectUrl>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<Nullable>enable</Nullable>
<DefineConstants>$(DefineConstants);AZURE_NULLABLE</DefineConstants>
</PropertyGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions sdk/mixedreality/Azure.MixedReality.Authentication/src/MixedRealityStsClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public class MixedRealityStsClient
/// <param name="accountDomain">The Mixed Reality service account domain.</param>
/// <param name="keyCredential">The Mixed Reality service account primary or secondary key credential.</param>
/// <param name="options">The options.</param>
public MixedRealityStsClient(Guid accountId, string accountDomain, AzureKeyCredential keyCredential, MixedRealityStsClientOptions? options = null)
public MixedRealityStsClient(Guid accountId, string accountDomain, AzureKeyCredential keyCredential, MixedRealityStsClientOptions options = null)
: this(accountId, AuthenticationEndpoint.ConstructFromDomain(accountDomain), new MixedRealityAccountKeyCredential(accountId, keyCredential), options) { }

/// <summary>
Expand All @@ -47,7 +47,7 @@ public MixedRealityStsClient(Guid accountId, string accountDomain, AzureKeyCrede
/// <param name="endpoint">The Mixed Reality STS service endpoint.</param>
/// <param name="keyCredential">The Mixed Reality service account primary or secondary key credential.</param>
/// <param name="options">The options.</param>
public MixedRealityStsClient(Guid accountId, Uri endpoint, AzureKeyCredential keyCredential, MixedRealityStsClientOptions? options = null)
public MixedRealityStsClient(Guid accountId, Uri endpoint, AzureKeyCredential keyCredential, MixedRealityStsClientOptions options = null)
: this(accountId, endpoint, new MixedRealityAccountKeyCredential(accountId, keyCredential), options) { }

/// <summary>
Expand All @@ -57,7 +57,7 @@ public MixedRealityStsClient(Guid accountId, Uri endpoint, AzureKeyCredential ke
/// <param name="accountDomain">The Mixed Reality service account domain.</param>
/// <param name="credential">The credential used to access the Mixed Reality service.</param>
/// <param name="options">The options.</param>
public MixedRealityStsClient(Guid accountId, string accountDomain, TokenCredential credential, MixedRealityStsClientOptions? options = null)
public MixedRealityStsClient(Guid accountId, string accountDomain, TokenCredential credential, MixedRealityStsClientOptions options = null)
: this(accountId, AuthenticationEndpoint.ConstructFromDomain(accountDomain), credential, options) { }

/// <summary>
Expand All @@ -67,7 +67,7 @@ public MixedRealityStsClient(Guid accountId, string accountDomain, TokenCredenti
/// <param name="endpoint">The Mixed Reality STS service endpoint.</param>
/// <param name="credential">The credential used to access the Mixed Reality service.</param>
/// <param name="options">The options.</param>
public MixedRealityStsClient(Guid accountId, Uri endpoint, TokenCredential credential, MixedRealityStsClientOptions? options = null)
public MixedRealityStsClient(Guid accountId, Uri endpoint, TokenCredential credential, MixedRealityStsClientOptions options = null)
{
Argument.AssertNotDefault(ref accountId, nameof(accountId));
Argument.AssertNotNull(endpoint, nameof(endpoint));
Expand Down