Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] OOM in tests. Force 64bit architecture in tests. #20303

Closed
wants to merge 0 commits into from

Conversation

kasobol-msft
Copy link
Contributor

@kasobol-msft kasobol-msft commented Apr 12, 2021

Related to #20301

  • added test to check if test process is 64bit
  • forced architecture in test run via --runtime switch

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Apr 12, 2021
@kasobol-msft
Copy link
Contributor Author

/azp run net - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kasobol-msft kasobol-msft changed the title [Storage] OOM in tests. [Storage] OOM in tests. Force 64bit architecture in tests. Apr 12, 2021
Copy link
Member

@benbp benbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eng/pipelines/templates/stages/platform-matrix.json Outdated Show resolved Hide resolved
eng/pipelines/templates/stages/platform-matrix.json Outdated Show resolved Hide resolved
@pakrym
Copy link
Contributor

pakrym commented Apr 12, 2021

LGTM, I'm very surprised by default local tests running 32bit.

@@ -40,6 +43,7 @@
},
"net5.0": {
"TestTargetFramework": "net5.0"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: newline here.

@benbp
Copy link
Member

benbp commented Apr 12, 2021

@pakrym yeah perhaps there's a higher level config or dotnet or OS setting that's making it use a 32-bit default here?

@benbp
Copy link
Member

benbp commented Apr 12, 2021

Also are we sure there are no other common, non-OS specific ways to tell either dotnet or nunit to run 64 bit (i.e. not via the command line, since apparently we don't have a general flag for that at least for --runtime).

@kasobol-msft
Copy link
Contributor Author

Also are we sure there are no other common, non-OS specific ways to tell either dotnet or nunit to run 64 bit (i.e. not via the command line, since apparently we don't have a general flag for that at least for --runtime).

Been talking to @pakrym . We'll try this https://stackoverflow.com/questions/3155492/how-do-i-specify-the-platform-for-msbuild instead. seems to be promising so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants