-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage] OOM in tests. Force 64bit architecture in tests. #20303
Conversation
/azp run net - storage - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'm very surprised by default local tests running 32bit. |
@@ -40,6 +43,7 @@ | |||
}, | |||
"net5.0": { | |||
"TestTargetFramework": "net5.0" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: newline here.
@pakrym yeah perhaps there's a higher level config or dotnet or OS setting that's making it use a 32-bit default here? |
Also are we sure there are no other common, non-OS specific ways to tell either dotnet or nunit to run 64 bit (i.e. not via the command line, since apparently we don't have a general flag for that at least for |
Been talking to @pakrym . We'll try this https://stackoverflow.com/questions/3155492/how-do-i-specify-the-platform-for-msbuild instead. seems to be promising so far. |
6f64367
to
7a66f19
Compare
Related to #20301
--runtime
switch