Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisions from the MAA API Review #20558

Merged
merged 55 commits into from
Apr 29, 2021
Merged

Revisions from the MAA API Review #20558

merged 55 commits into from
Apr 29, 2021

Commits on Apr 20, 2021

  1. Revisions from the MAA API Review

    @LarryOsterman
    LarryOsterman committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    30e5042 View commit details
    Browse the repository at this point in the history

  2. Added MAA code owners

    @LarryOsterman
    LarryOsterman committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    65b8d3c View commit details
    Browse the repository at this point in the history

  3. Fixed typo in codeowners

    @LarryOsterman
    LarryOsterman committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    6929e97 View commit details
    Browse the repository at this point in the history

  4. Updated API definitions

    @LarryOsterman
    LarryOsterman committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c560614 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2021

  1. Fixed typo in README.md introduced while cleaning up md errors

    @LarryOsterman
    LarryOsterman committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    9f3524a View commit details
    Browse the repository at this point in the history

  2. More pull request feedback

    @LarryOsterman
    LarryOsterman committed Apr 21, 2021
    Configuration menu
    Copy the full SHA
    18b7990 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Next round of API review feedback

    @LarryOsterman
    LarryOsterman committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    d659679 View commit details
    Browse the repository at this point in the history

  2. Regenerated swagger

    @LarryOsterman
    LarryOsterman committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    c5e50e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2021

  1. Obsoleted deprecated claims in output token

    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6f1cde1 View commit details
    Browse the repository at this point in the history

  2. Renamed AttestRequest -> AttestationRequst

    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c4fb52c View commit details
    Browse the repository at this point in the history

  3. Update sdk/attestation/Azure.Security.Attestation/README.md 

    Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b1610a5 View commit details
    Browse the repository at this point in the history

  4. Updated with code review feedback from Jesse Squires

    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e6d80da View commit details
    Browse the repository at this point in the history

  5. Merge branch 'LarryO-ApiReviewFeedback' of https://github.com/LarryOs… 

    …terman/azure-sdk-for-net into LarryO-ApiReviewFeedback
    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6561fd5 View commit details
    Browse the repository at this point in the history

  6. Updated APIs

    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f37d8a4 View commit details
    Browse the repository at this point in the history

  7. Updated snippets

    @LarryOsterman
    LarryOsterman committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9f47173 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2021

  1. Nightly tests also run samples

    @LarryOsterman
    LarryOsterman committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    069f515 View commit details
    Browse the repository at this point in the history

  2. Added locationShortName to tests.yml to fix live test failures on *nix

    @LarryOsterman
    LarryOsterman committed Apr 24, 2021
    Configuration menu
    Copy the full SHA
    ad0450d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    85fbf83 View commit details
    Browse the repository at this point in the history

  2. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    121f324 View commit details
    Browse the repository at this point in the history

  3. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    ad3d0c7 View commit details
    Browse the repository at this point in the history

  4. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    47b675c View commit details
    Browse the repository at this point in the history

  5. Update sdk/attestation/Azure.Security.Attestation/src/Models/Attestat… 

    …ionSigner.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    012853e View commit details
    Browse the repository at this point in the history

  6. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b646363 View commit details
    Browse the repository at this point in the history

  7. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …nValidationOptions.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    a1b4fb8 View commit details
    Browse the repository at this point in the history

  8. Update sdk/attestation/Azure.Security.Attestation/src/Models/PolicyCe… 

    …rtificateModification.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b3f76a4 View commit details
    Browse the repository at this point in the history

  9. Update sdk/attestation/Azure.Security.Attestation/src/Models/PolicyCe… 

    …rtificateModification.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 26, 2021
    Configuration menu
    Copy the full SHA
    4809fdf View commit details
    Browse the repository at this point in the history

  10. Pull request feedback

    @LarryOsterman
    LarryOsterman committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    7eb6f68 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'LarryO-ApiReviewFeedback' of https://github.com/LarryOs… 

    …terman/azure-sdk-for-net into LarryO-ApiReviewFeedback
    @LarryOsterman
    LarryOsterman committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    5a74e5c View commit details
    Browse the repository at this point in the history

  12. Regenerate API surface

    @LarryOsterman
    LarryOsterman committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    d09153d View commit details
    Browse the repository at this point in the history

  13. Added a reference to the MAA Sample code to readme file; Cleaned up s… 

    …ome doccomments in AttestationSigner class
    @LarryOsterman
    LarryOsterman committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    b37d489 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. All validation exceptions return a new AttestationTokenValidationFail… 

    …edException; standardized token validation logic
    @LarryOsterman
    LarryOsterman committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    f7669b5 View commit details
    Browse the repository at this point in the history

  2. Updated changelog to flag more breaking changes; cleaned up some docc… 

    …omments
    @LarryOsterman
    LarryOsterman committed Apr 27, 2021
    Configuration menu
    Copy the full SHA
    4bf60b2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Added model factory for private model types; Added test collateral fo… 

    …r model factory, which exposed a raft of issues in the exported types
    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    dc149c1 View commit details
    Browse the repository at this point in the history

  2. Updated exported API - PolicyTokenHash is now a BinaryData

    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    58b5844 View commit details
    Browse the repository at this point in the history

  3. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    4b59011 View commit details
    Browse the repository at this point in the history

  4. Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdmi… 

    …nistrationClient.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    9640944 View commit details
    Browse the repository at this point in the history

  5. Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdmi… 

    …nistrationClient.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    d479052 View commit details
    Browse the repository at this point in the history

  6. Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdmi… 

    …nistrationClient.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    d076102 View commit details
    Browse the repository at this point in the history

  7. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    0c37f46 View commit details
    Browse the repository at this point in the history

  8. Update sdk/attestation/Azure.Security.Attestation/src/AttestationAdmi… 

    …nistrationClient.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    086c1f3 View commit details
    Browse the repository at this point in the history

  9. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    b98c829 View commit details
    Browse the repository at this point in the history

  10. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    5cc34cf View commit details
    Browse the repository at this point in the history

  11. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    7459a75 View commit details
    Browse the repository at this point in the history

  12. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    6d060a0 View commit details
    Browse the repository at this point in the history

  13. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    92f6e93 View commit details
    Browse the repository at this point in the history

  14. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    69f3587 View commit details
    Browse the repository at this point in the history

  15. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    1af7d0e View commit details
    Browse the repository at this point in the history

  16. Apply suggestions from code review 

    Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    bc62864 View commit details
    Browse the repository at this point in the history

  17. Added descriptive comments

    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    ad30053 View commit details
    Browse the repository at this point in the history

  18. Update sdk/attestation/Azure.Security.Attestation/src/AttestationToke… 

    …n.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    48c6d9a View commit details
    Browse the repository at this point in the history

  19. Update sdk/attestation/Azure.Security.Attestation/src/Models/Attestat… 

    …ionSigner.cs

Co-authored-by: Jesse Squire <[email protected]>
    @LarryOsterman @jsquire
    LarryOsterman and jsquire authored Apr 28, 2021
    Configuration menu
    Copy the full SHA
    49335dc View commit details
    Browse the repository at this point in the history

  20. Merged token validation failed exception to shared helper.

    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    21b0c0e View commit details
    Browse the repository at this point in the history

  21. Merge branch 'master' into LarryO-ApiReviewFeedback

    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    b5641a6 View commit details
    Browse the repository at this point in the history

  22. Updated generated elements

    @LarryOsterman
    LarryOsterman committed Apr 28, 2021
    Configuration menu
    Copy the full SHA
    05c9172 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2021

  1. Issue Azure#20745

    @LarryOsterman
    LarryOsterman committed Apr 29, 2021
    Configuration menu
    Copy the full SHA
    cb00497 View commit details
    Browse the repository at this point in the history