Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch receive fixes #21566

Merged
merged 7 commits into from
Jun 6, 2021
Merged

Conversation

JoshLove-msft
Copy link
Member

@JoshLove-msft JoshLove-msft commented Jun 3, 2021

Fixes #21382

  • Adds more determinism to stopping a host that uses batch receive by allowing processing/autocompletion to finish. Uses the same strategy introduced in SB SDK to allow batch receive to cancel early to avoid waiting for a long time when shutting down.
  • Prevents error when autoCompleteMessages = true and user completes message in batch function (already worked like this for single dispatch functions)

@ghost ghost added the Service Bus label Jun 3, 2021
@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to Pavel for the final approval, as he's more familiar with the Functions integration than I.

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/check-enforcer reset

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft
Copy link
Member Author

/azp run net - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JoshLove-msft JoshLove-msft enabled auto-merge (squash) June 6, 2021 04:29
@JoshLove-msft JoshLove-msft merged commit 8155a11 into Azure:master Jun 6, 2021
paul-cheung pushed a commit to paul-cheung/azure-sdk-for-net that referenced this pull request Jun 7, 2021
* Batch receive fixes

* Use AwaitWithCancellation

* volatile

* Remove unnecessary catch

* Fix tests

* Fix flaky tests

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not attempt to settle message when already settled for multiple dispatch functions
3 participants