[MetricsAdvisor] Renamed DataSourceCredential types #22119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinelski
added
the
Client
ghost
added
the
maririos
reviewed
Jun 24, 2021
| - The whole `DatasourceCredential` API has been renamed to `DataSourceCredential`. This includes renames in types, methods, and properties. | ||
| - The whole `DatasourceCredential` API has been renamed to `DataSourceCredential`. This includes renames in methods, method parameters, and properties. | ||
| - Renamed class `DatasourceCredential` to `DataSourceCredentialEntity`. | ||
| - Renamed class `DataLakeGen2SharedKeyDatasourceCredential` to `DataSourceDataLakeGen2SharedKey`. |
There was a problem hiding this comment.
ohh cool. Just for my own learning, what was the reason for moving DataSource to the beginning of the types?
There was a problem hiding this comment.
We don't like ending in "Credential" that much because this can get mixed up with credential types in Identity. I'm okay with just appending "CredentialIdentity" to everything, but other languages are taking this approach, so I'm following along for consistency. The reasoning is something like "DataSourceSqlConnectionString" is a "data source's SQL connection string".
In terms of advantage, I can only think of:
- Types names get shorter (I've heard that
DataLakeGen2SharedKeyDataSourceCredentialis too long more than once). - All credential types get organized in the same place because of alphabetical order.
maririos
approved these changes
Jun 24, 2021
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
Show resolved
Hide resolved
sdk/metricsadvisor/Azure.AI.MetricsAdvisor/src/MetricsAdvisorAdministrationClient.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback from architects + cross-language consistency.
DataSourceCredentialhas been renamed toDataSourceCredentialEntity.<credential-type>DataSourceCredential. They have been renamed toDataSource<credential-type>. Example: "ServicePrincipalDataSourceCredential" => "DataSourceServicePrincipal".