Update Delete Sample #22138
Merged
Update Delete Sample #22138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
requested review from
tg-msft,
pakrym,
KrzysztofCwalina,
jeremymeng,
pallavit and
seankane-msft
pakrym
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We considered parallelizing the asynchronous Delete sample by adding functionality into
Azure.Core. We learned, however, that .NET 6 will be providing an implementation ofParallel.ForEachAsync, and thatIAsyncEnumerable.ForEachAsyncis implemented in theSystem.Linq.Asyncpackage. Given this, it doesn't make sense to add this functionality to Core. Instead, we're noting the recommended path for parallelizing the sample and leaving it sequential.Fixes #21675
Fixes #21820