-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netcoreapp3.1 migration #22545
netcoreapp3.1 migration #22545
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question but otherwise looks reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.NET Core 2.1 is supported until August 21st, 2021. Isn't this premature to test our lowest common denominator?
Apart from that and a potentially minor test change for Key Vault it looks fine, but I'd like to answer this question first.
sdk/keyvault/Azure.Security.KeyVault.Certificates/tests/PemReaderTests.cs
Outdated
Show resolved
Hide resolved
We haven't seen many netcoreapp2.1-specific product issues. So I don't think it's worth waiting until August 21 to disable it. |
…derTests.cs Co-authored-by: Heath Stewart <[email protected]>
Update readme.python.md (Azure#22545) * Update readme.python.md * Update readme.python.md * Update readme.python.md --------- Co-authored-by: Yuchao Yan <[email protected]>
No description provided.