Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netcoreapp3.1 migration #22545

Merged
merged 12 commits into from
Jul 20, 2021
Merged

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Jul 8, 2021

No description provided.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question but otherwise looks reasonable.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.NET Core 2.1 is supported until August 21st, 2021. Isn't this premature to test our lowest common denominator?

Apart from that and a potentially minor test change for Key Vault it looks fine, but I'd like to answer this question first.

@pakrym
Copy link
Contributor Author

pakrym commented Jul 19, 2021

.NET Core 2.1 is supported until August 21st, 2021. Isn't this premature to test our lowest common denominator?

We haven't seen many netcoreapp2.1-specific product issues. So I don't think it's worth waiting until August 21 to disable it.

@pakrym pakrym merged commit b314648 into Azure:main Jul 20, 2021
@pakrym pakrym deleted the pakrym/netcoreapp3-1-migration branch July 20, 2021 00:02
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 10, 2023
Update readme.python.md (Azure#22545)

* Update readme.python.md

* Update readme.python.md

* Update readme.python.md

---------

Co-authored-by: Yuchao Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants