[Event Hubs] Processor Event Dispatch Cancellation #22695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
christothes
approved these changes
Jul 16, 2021
The focus of these changes is to fix the loop responsible for dispatching events to the handler for processing so that it respects cancellation when the processor signals the associated token. Currently, the loop will dispatch all events in the batch to the handler, potentially causing duplicate processing and checkpoint interleaving.
jsquire
force-pushed
the
eventhubs/respect-cancellation
branch
from
6826289
to
8fadb27
Compare
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Mar 3, 2023
Azure SignalR - Adding new api-version 2023-02-01 (Azure#22695) * copy from existing api-version before adding new one * add new api-version 2023-02-01 * remove minLength * add back minLength
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Mar 3, 2023
Azure SignalR - Adding new api-version 2023-02-01 (Azure#22695) * copy from existing api-version before adding new one * add new api-version 2023-02-01 * remove minLength * add back minLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix the loop responsible for dispatching events to the handler for processing so that it respects cancellation when the processor signals the associated token. Currently, the loop will dispatch all events in the batch to the handler, potentially causing duplicate processing and checkpoint interleaving.