Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SqlManagement] Ledger SDK Update #23137

Merged
merged 3 commits into from
Aug 12, 2021

Conversation

rewongmicrosoft
Copy link
Contributor

@rewongmicrosoft rewongmicrosoft commented Aug 5, 2021

Ready to be merged
Swagger PR: Azure/azure-rest-api-specs#15368

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@rewongmicrosoft
Copy link
Contributor Author

Ready to be merged

@fengzhou-msft
Copy link
Member

@rewongmicrosoft can you update the CHANGELOG.md file?

@rewongmicrosoft
Copy link
Contributor Author

@fengzhou-msft which changelog are you referring to? We have description of these changes in Microsoft.Azure.Management.Sql.csproj

@fengzhou-msft
Copy link
Member

@fengzhou-msft which changelog are you referring to? We have description of these changes in Microsoft.Azure.Management.Sql.csproj

I mean this one: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/sqlmanagement/Azure.ResourceManager.Sql/CHANGELOG.md.

@rewongmicrosoft
Copy link
Contributor Author

@fengzhou-msft which changelog are you referring to? We have description of these changes in Microsoft.Azure.Management.Sql.csproj

I mean this one: https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/sqlmanagement/Azure.ResourceManager.Sql/CHANGELOG.md.

Do you want me to add a new entry for this version? We are following the convention of adding change descriptions in the .csproj file, not in the changelog so that may be confusing to put it there instead

@fengzhou-msft
Copy link
Member

It's fine if that's the convention.

@fengzhou-msft fengzhou-msft merged commit 4c10b87 into Azure:main Aug 12, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Mar 20, 2023
To add Update Cost Details Field Link in GenerateCostDetailsReport (Azure#23137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants