Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Dynamic Concurrency support to WebJobs SDK ServiceBus Extension #23450

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Adding Dynamic Concurrency support to WebJobs SDK ServiceBus Extension #23450

merged 1 commit into from
Sep 17, 2021

Conversation

mathewc
Copy link
Member

@mathewc mathewc commented Aug 20, 2021 •
edited
Loading

Implements the Dynamic Concurrency features in Azure/azure-functions-host#7300.

Related PR for Dynamic Concurrency support in Storage Queues extension: #22283

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Service Bus label Aug 20, 2021
@mathewc mathewc marked this pull request as draft August 20, 2021 20:04
@mathewc mathewc requested a review from paulbatum August 20, 2021 20:06
mathewc
mathewc commented Aug 20, 2021
View reviewed changes
NuGet.Config Outdated Show resolved Hide resolved
@mathewc mathewc force-pushed the dynamic-concurrency-servicebus2 branch from 59c5e91 to 8cf632d Compare August 20, 2021 20:14
@mathewc mathewc mentioned this pull request Aug 20, 2021
Merged
11 tasks
@mathewc mathewc force-pushed the dynamic-concurrency-servicebus2 branch from 8cf632d to 132ff52 Compare September 1, 2021 21:57
@check-enforcer
Copy link

check-enforcer bot commented Sep 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@mathewc
Copy link
Member Author

mathewc commented Sep 2, 2021

/check-enforcer evaluate

@mathewc mathewc force-pushed the dynamic-concurrency-servicebus2 branch from 132ff52 to ba7f950 Compare September 2, 2021 19:16
@mathewc mathewc force-pushed the dynamic-concurrency-servicebus2 branch from ba7f950 to e3123b1 Compare September 17, 2021 18:06
@mathewc mathewc marked this pull request as ready for review September 17, 2021 18:07
@mathewc mathewc force-pushed the dynamic-concurrency-servicebus2 branch from e3123b1 to 7bb6f42 Compare September 17, 2021 20:44
@JoshLove-msft JoshLove-msft merged commit d8770b7 into main Sep 17, 2021
@JoshLove-msft JoshLove-msft deleted the dynamic-concurrency-servicebus2 branch September 17, 2021 21:16
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Apr 18, 2023
@namanag16 @forteddyt
@srivatsasinha @komo23x
CodeGen from PR 23450 in Azure/azure-rest-api-specs
e7da295 
Release machinelearningservices microsoft.machine learning services 2023 04 01 (Azure#23450)

* Adds base for updating Microsoft.MachineLearningServices from version stable/2022-10-01 to version 2023-04-01

* Updates readme

* Updates API version in new specs and examples

* [Stable] Bring Back schedule shutdown MLC models (Azure#23039)

* bring back schedule shutdown MLC models

* add description

---------

Co-authored-by: Naman Agarwal <[email protected]>

* add minLength:1 prop to required strings (Azure#23109)

* [Stable] Add IdleShutdown properties and api (Azure#23042)

* [Stable] Add IdleShutdown properties and api

* update version

* remove api to update IdleShutdownSetting

* Delete example

---------

Co-authored-by: Naman Agarwal <[email protected]>

* Pushing new features in stable swagger (Azure#23071)

* Pushing new features in stable swagger

* Added example file

* Triggering retest

* Fixed version issue

* Triggering retest

* Removing OS Patching

* Changes as per feedback, and add os patching back

* Fix formatting

* Removed Custom Service Update API

* Fixed Example Files

* Added as per review comments

* Added as per review comments

* Retrigger test

---------

Co-authored-by: Srivatsa Sinha <[email protected]>

* Add Registries 2023-04-01 Swagger (Azure#23085)

* add swagger + examples

* fix readme

* fix readme

* switching to autogenerated registries swagger

* fix spellcheck

* update ga examples

* previous API version for comparison = 2023-02-01-preview

* new API version for comparison = 2023-04-01

* update examples

* update swagger, examples to fix pr gates

* fix lint diff errors

* delete should have a 202 response, update createorupdate examples, fix removeRegions operation

* removeRegions -> LRO POST operation

* fix LRO options on removeRegions

* add registryNameParamert

* update swagger

* update

* PATCH property should have sku, identity properties

* fix example

---------

Co-authored-by: Komal Yadav <[email protected]>

* MFE April 2023 staging (Azure#23164)

* add latest mfe.json

* updated examples

* add wasbs to known words

* swap pendingupload to proper naming

* align RPs on Azure Machine Learning Services

* rename pendingUpload to verb: startPendingUpload

* remove trailing slash startpendingupload

* improve descriptions

* add pattern to all resource name types + examples

* update original-uri -> azure-async-operation

* remove wasbs and mark credential usage as secret

* test is changing all to azure-async-operation causes breaking change

* the code is implemented where the original-uri is where you will find the final object post-polling

* update examples to remove wasbsUri

* reference registries instead for RegistryName

* remove wasbs

* original-uri -> azure-async-operation

* update examples to empty secrets

* CreateOrUpdatePendingUpload -> CreateOrUpdateStartPendingUpload

* add pattern for workspaceName

* x-ms-secret on the SASUri

* switch back to original-uri given update from auto-rest folks

---------

Co-authored-by: Kayla Ames <[email protected]>

* update compute examples to ReadOnly

* v5->v3

* PartialManagedServiceIdentity -> RegistryPartialManagedServiceIdentity

* update ID for delete/cancel job/schedule location header

* PrivateEndpointConnection -> RegistryPrivateEndpointConnection

* more renames for Registry

* align mlc with arm

* update registry examples

* update registryPrivateLinkServiceConnectionState in examples

* update description arm id for registryPrivateEndpointConnections

* update to preview

---------

Co-authored-by: Naman Agarwal <[email protected]>
Co-authored-by: Naman Agarwal <[email protected]>
Co-authored-by: Teddy Todorov <[email protected]>
Co-authored-by: srivatsasinha <[email protected]>
Co-authored-by: Srivatsa Sinha <[email protected]>
Co-authored-by: Komal Yadav <[email protected]>
Co-authored-by: Komal Yadav <[email protected]>
Co-authored-by: Kayla Ames <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft approved these changes

@paulbatum paulbatum Awaiting requested review from paulbatum

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathewc @JoshLove-msft