-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314
Conversation
Hi @damodaravadhani, There are some breaking changes in this PR. If they are expected, you need to bump the major version and then I will merge it. |
@@ -511,7 +511,7 @@ public static async Task<AccessKeys> ListKeysAsync(this IEventHubsOperations ope | |||
/// Optional, if the key value provided, is set for KeyType or autogenerated | |||
/// Key value set for keyType | |||
/// </param> | |||
public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, KeyType keyType, string key = default(string)) | |||
public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, string keyType, string key = default(string)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -52,8 +57,8 @@ public ArmDisasterRecovery() | |||
/// pending to be replicated.</param> | |||
/// <param name="systemData">The system meta data relating to this | |||
/// resource.</param> | |||
public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData)) | |||
: base(id, name, type) | |||
public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), string location = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
/// <param name="systemData">The system meta data relating to this | ||
/// resource.</param> | ||
public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), SystemData systemData = default(SystemData)) | ||
: base(id, name, type) | ||
public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), string location = default(string), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -45,8 +50,8 @@ public ConsumerGroup() | |||
/// stored.</param> | |||
/// <param name="systemData">The system meta data relating to this | |||
/// resource.</param> | |||
public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData)) | |||
: base(id, name, type) | |||
public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
/// failed.</param> | ||
public ErrorResponse(string code = default(string), string message = default(string)) | ||
/// <param name="error">The error object.</param> | ||
public ErrorResponse(ErrorDetail error = default(ErrorDetail)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -55,8 +60,8 @@ public Eventhub() | |||
/// description</param> | |||
/// <param name="systemData">The system meta data relating to this | |||
/// resource.</param> | |||
public Eventhub(string id = default(string), string name = default(string), string type = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData)) | |||
: base(id, name, type) | |||
public Eventhub(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -48,8 +53,8 @@ public NetworkRuleSet() | |||
/// values include: 'Enabled', 'Disabled'</param> | |||
/// <param name="systemData">The system meta data relating to this | |||
/// resource.</param> | |||
public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData)) | |||
: base(id, name, type) | |||
public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), string location = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
/// <param name="display">Display of the operation</param> | ||
/// <param name="origin">Origin of the operation</param> | ||
/// <param name="properties">Properties of the operation</param> | ||
public Operation(string name = default(string), bool? isDataAction = default(bool?), OperationDisplay display = default(OperationDisplay), string origin = default(string), object properties = default(object)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -44,8 +49,8 @@ public PrivateEndpointConnection() | |||
/// 'Updating', 'Deleting', 'Succeeded', 'Canceled', 'Failed'</param> | |||
/// <param name="systemData">The system meta data relating to this | |||
/// resource.</param> | |||
public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData)) | |||
: base(id, name, type) | |||
public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), string location = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -36,7 +37,7 @@ public RegenerateAccessKeyParameters() | |||
/// include: 'PrimaryKey', 'SecondaryKey'</param> | |||
/// <param name="key">Optional, if the key value provided, is set for | |||
/// KeyType or autogenerated Key value set for keyType</param> | |||
public RegenerateAccessKeyParameters(KeyType keyType, string key = default(string)) | |||
public RegenerateAccessKeyParameters(string keyType, string key = default(string)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
@@ -599,7 +639,7 @@ public static async Task<AccessKeys> ListKeysAsync(this INamespacesOperations op | |||
/// Optional, if the key value provided, is set for KeyType or autogenerated | |||
/// Key value set for keyType | |||
/// </param> | |||
public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, KeyType keyType, string key = default(string)) | |||
public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, string keyType, string key = default(string)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change
Add 2023-09-01-preview for appplatform (Azure#25501) * Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (Azure#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (Azure#25322) * support war file deployment (Azure#25312) Co-authored-by: Yi Li <[email protected]> * Fix exmaple for api portal api try-out feature (Azure#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (Azure#25331) * Add gateway apm reference (Azure#25408) * Add expand parameter for list deployment (Azure#25411) * Add expand parameter for list deployments API (Azure#25471) * change order of expand (Azure#25587) * Update readme.go.md (Azure#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (Azure#25677) Fix exmaple for api portal api try-out feature (Azure#25337)" * add API to list all server versions (Azure#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <[email protected]> * use enum for autoSync (Azure#25722) * Update appplatform.json (Azure#25724) * certificate - rename enum (Azure#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <[email protected]> Co-authored-by: Mason Chen <[email protected]> Co-authored-by: Yi Li <[email protected]> Co-authored-by: Yi Li <[email protected]> Co-authored-by: Jeff <[email protected]> Co-authored-by: ninpan-ms <[email protected]>
All SDK Contribution checklist:
Swagger spec link : Azure/azure-rest-api-specs#16363
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.