SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314

damodaravadhani · 2021-11-15T03:57:14Z

All SDK Contribution checklist:

Swagger spec link : Azure/azure-rest-api-specs#16363

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

Yao725 · 2021-11-18T03:28:52Z

Hi @damodaravadhani, There are some breaking changes in this PR. If they are expected, you need to bump the major version and then I will merge it.

Yao725 · 2021-11-26T01:41:05Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/EventHubsOperationsExtensions.cs

@@ -511,7 +511,7 @@ public static async Task<AccessKeys> ListKeysAsync(this IEventHubsOperations ope
            /// Optional, if the key value provided, is set for KeyType or autogenerated
            /// Key value set for keyType
            /// </param>
-            public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, KeyType keyType, string key = default(string))
+            public static AccessKeys RegenerateKeys(this IEventHubsOperations operations, string resourceGroupName, string namespaceName, string eventHubName, string authorizationRuleName, string keyType, string key = default(string))


breaking change

Yao725 · 2021-11-26T01:43:23Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/ArmDisasterRecovery.cs

@@ -52,8 +57,8 @@ public ArmDisasterRecovery()
        /// pending to be replicated.</param>
        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public ArmDisasterRecovery(string id = default(string), string name = default(string), string type = default(string), string location = default(string), ProvisioningStateDR? provisioningState = default(ProvisioningStateDR?), string partnerNamespace = default(string), string alternateName = default(string), RoleDisasterRecovery? role = default(RoleDisasterRecovery?), long? pendingReplicationOperationsCount = default(long?), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:43:47Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/AuthorizationRule.cs

        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public AuthorizationRule(IList<string> rights, string id = default(string), string name = default(string), string type = default(string), string location = default(string), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:44:19Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/ConsumerGroup.cs

@@ -45,8 +50,8 @@ public ConsumerGroup()
        /// stored.</param>
        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public ConsumerGroup(string id = default(string), string name = default(string), string type = default(string), string location = default(string), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), string userMetadata = default(string), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:47:33Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/ErrorResponse.cs

-        /// failed.</param>
-        public ErrorResponse(string code = default(string), string message = default(string))
+        /// <param name="error">The error object.</param>
+        public ErrorResponse(ErrorDetail error = default(ErrorDetail))


breaking change

Yao725 · 2021-11-26T01:47:54Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/Eventhub.cs

@@ -55,8 +60,8 @@ public Eventhub()
        /// description</param>
        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public Eventhub(string id = default(string), string name = default(string), string type = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public Eventhub(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IList<string> partitionIds = default(IList<string>), System.DateTime? createdAt = default(System.DateTime?), System.DateTime? updatedAt = default(System.DateTime?), long? messageRetentionInDays = default(long?), long? partitionCount = default(long?), EntityStatus? status = default(EntityStatus?), CaptureDescription captureDescription = default(CaptureDescription), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:48:37Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/NetworkRuleSet.cs

@@ -48,8 +53,8 @@ public NetworkRuleSet()
        /// values include: 'Enabled', 'Disabled'</param>
        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public NetworkRuleSet(string id = default(string), string name = default(string), string type = default(string), string location = default(string), bool? trustedServiceAccessEnabled = default(bool?), string defaultAction = default(string), IList<NWRuleSetVirtualNetworkRules> virtualNetworkRules = default(IList<NWRuleSetVirtualNetworkRules>), IList<NWRuleSetIpRules> ipRules = default(IList<NWRuleSetIpRules>), string publicNetworkAccess = default(string), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:49:14Z

sdk/eventhub/Microsoft.Azure.Management.EventHub/src/Generated/Models/Operation.cs

+        /// <param name="display">Display of the operation</param>
+        /// <param name="origin">Origin of the operation</param>
+        /// <param name="properties">Properties of the operation</param>
+        public Operation(string name = default(string), bool? isDataAction = default(bool?), OperationDisplay display = default(OperationDisplay), string origin = default(string), object properties = default(object))


breaking change

Yao725 · 2021-11-26T01:49:58Z

...enthub/Microsoft.Azure.Management.EventHub/src/Generated/Models/PrivateEndpointConnection.cs

@@ -44,8 +49,8 @@ public PrivateEndpointConnection()
        /// 'Updating', 'Deleting', 'Succeeded', 'Canceled', 'Failed'</param>
        /// <param name="systemData">The system meta data relating to this
        /// resource.</param>
-        public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData))
-            : base(id, name, type)
+        public PrivateEndpointConnection(string id = default(string), string name = default(string), string type = default(string), string location = default(string), PrivateEndpoint privateEndpoint = default(PrivateEndpoint), ConnectionState privateLinkServiceConnectionState = default(ConnectionState), string provisioningState = default(string), SystemData systemData = default(SystemData))


breaking change

Yao725 · 2021-11-26T01:51:11Z

...ub/Microsoft.Azure.Management.EventHub/src/Generated/Models/RegenerateAccessKeyParameters.cs

@@ -36,7 +37,7 @@ public RegenerateAccessKeyParameters()
        /// include: 'PrimaryKey', 'SecondaryKey'</param>
        /// <param name="key">Optional, if the key value provided, is set for
        /// KeyType or autogenerated Key value set for keyType</param>
-        public RegenerateAccessKeyParameters(KeyType keyType, string key = default(string))
+        public RegenerateAccessKeyParameters(string keyType, string key = default(string))


breaking change

Yao725 · 2021-11-26T01:54:22Z

...eventhub/Microsoft.Azure.Management.EventHub/src/Generated/NamespacesOperationsExtensions.cs

@@ -599,7 +639,7 @@ public static async Task<AccessKeys> ListKeysAsync(this INamespacesOperations op
            /// Optional, if the key value provided, is set for KeyType or autogenerated
            /// Key value set for keyType
            /// </param>
-            public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, KeyType keyType, string key = default(string))
+            public static AccessKeys RegenerateKeys(this INamespacesOperations operations, string resourceGroupName, string namespaceName, string authorizationRuleName, string keyType, string key = default(string))


breaking change

Add 2023-09-01-preview for appplatform (Azure#25501) * Adds base for updating Microsoft.AppPlatform from version preview/2023-07-01-preview to version 2023-09-01-preview * Updates readme * Updates API version in new specs and examples * feat: fragment support swagger change (Azure#25314) * Add apiTryOutEnabledState properties for api portal for 2023-09-01-preview api (Azure#25322) * support war file deployment (Azure#25312) Co-authored-by: Yi Li <[email protected]> * Fix exmaple for api portal api try-out feature (Azure#25337) * Add property `autoSync` in `KeyVaultCertificateProperties` (Azure#25331) * Add gateway apm reference (Azure#25408) * Add expand parameter for list deployment (Azure#25411) * Add expand parameter for list deployments API (Azure#25471) * change order of expand (Azure#25587) * Update readme.go.md (Azure#25634) * Update readme.go.md * Update readme.python.md * Update readme.ruby.md * Revert api portal try out feature (Azure#25677) Fix exmaple for api portal api try-out feature (Azure#25337)" * add API to list all server versions (Azure#25720) * add API to list all server versions * refine list supported server version API * refine description --------- Co-authored-by: Yi Li <[email protected]> * use enum for autoSync (Azure#25722) * Update appplatform.json (Azure#25724) * certificate - rename enum (Azure#25723) * use enum for autoSync * rename enum * rename enum --------- Co-authored-by: guitarsheng <[email protected]> Co-authored-by: Mason Chen <[email protected]> Co-authored-by: Yi Li <[email protected]> Co-authored-by: Yi Li <[email protected]> Co-authored-by: Jeff <[email protected]> Co-authored-by: ninpan-ms <[email protected]>

New SDK for 2021-11-01 version with tests for SchemaRegistry

38f96f8

damodaravadhani requested review from allenjzhang, archerzz, ArcturusZhang, ArthurMa1978, fengzhou-msft, m-nash, markcowl and Yao725 as code owners November 15, 2021 03:57

openapi-assignment-bot bot assigned Yao725 Nov 15, 2021

ghost added the Event Hubs label Nov 15, 2021

Changed the versionto 4.0.0

d6bf201

Yao725 approved these changes Nov 19, 2021

View reviewed changes

Yao725 merged commit 6171084 into Azure:main Nov 19, 2021

Yao725 reviewed Nov 26, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314

SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314

damodaravadhani commented Nov 15, 2021

Yao725 commented Nov 18, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

Yao725 Nov 26, 2021

SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314

SDK for 2021-11-01 version for Event Hubs with tests for SchemaRegistry #25314

Conversation

damodaravadhani commented Nov 15, 2021

All SDK Contribution checklist:

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

Yao725 commented Nov 18, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment