[Event Hubs Client] Idempotent Error Handling #25586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
added
Event Hubs
Client
jsquire
requested review from
christothes,
deyaaeldeen,
conniey,
ramya-rao-a,
serkantkaraca,
yunhaoling,
richardpark-msft and
JoshLove-msft
sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubProducerClient.cs
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Producer/EventHubProducerClient.cs
Outdated
Show resolved
Hide resolved
JoshLove-msft
approved these changes
Nov 30, 2021
jsquire
force-pushed
the
eventhubs/idempotent-error
branch
from
a29fea7
to
b3d9d86
Compare
The focus of these changes is to ensure that the AMQP connection and link states are fully reset on any exception after retries are exhausted in order to ensure no data loss. In error scenarios with ambiguous outcomes, it is possible for the client and service state for idempotent sequencing to become out-of-sync with no way to detect or correct the problem. When this happens, it is possible that events being published are incorrectly identified by the service as duplicates and their receipt acknowledged. This leads the client to signal to callers that publishing was successful, though the events were ignored by the service and will never be available to be read. By resetting the connection and forcing the client to use a new publisher identifier, the service will reset state and perform the initial handshake with the client, ensuring that state is properly synchronized between them.
jsquire
force-pushed
the
eventhubs/idempotent-error
branch
from
b3d9d86
to
505a507
Compare
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Sep 4, 2023
Update readme.python.md (Azure#25586) * Update readme.python.md * Update readme.python.md
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Sep 4, 2023
Update readme.python.md (Azure#25586) * Update readme.python.md * Update readme.python.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to ensure that the AMQP connection and link states are fully reset on any exception after retries are exhausted in order to ensure no data loss.
In error scenarios with ambiguous outcomes, it is possible for the client and service state for idempotent sequencing to become out-of-sync with no way to detect or correct the problem. When this happens, it is possible that events being published are incorrectly identified by the service as duplicates and their receipt acknowledged. This leads the client to signal to callers that publishing was successful, though the events were ignored by the service and will never be available to be read.
By resetting the connection and forcing the client to use a new publisher identifier, the service will reset state and perform the initial handshake with the client, ensuring that state is properly synchronized between them.