Azure Compute SDK Changes for ProtectedSettingsFromKeyVault #25620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamusta-msft
requested review from
archerzz,
ArcturusZhang,
ArthurMa1978,
fengzhou-msft,
m-nash and
Yao725
as code owners
ghost
added
the
|
Hi @kamusta-msft , could you please fix the failed tests? |
|
@Yao725 |
|
/azp run |
|
Pull request contains merge conflicts. |
…tingsFromKeyVault2
ArthurMa1978
pushed a commit
that referenced
this pull request
Jan 27, 2022
* update with api version 2021-11-01 * update with api version 2021-11-01 * update virtualmachine to virtualMachine in swagger * update test to preserve resource group until finally block * test updates and new recordings * update from swagger sync * Added SDK changes for scaling VMSS with PublicIpPrefix (patch updates) (#26031) * Add RepairAction property to VMSS AutoRepairs feature (#25095) * Add RepairAction property to VMSS AutoRepairs feature * Include metadata file * Add session record and updated test * Update TestVMScaleSetScenarioOperations_OrchestrationService.json * Restore files that shouldn't have been changed * Add orchestration service record * Delete compute_resource-manager.txt Co-authored-by: Theodore Chang <[email protected]> * sdk gen (#25670) Co-authored-by: Chase Van Buskirk <[email protected]> * Added sdk changes for vmss vm customization (#25785) * Added sdk changes for vmss vm customization * Added sdk changes for vmss vm customization * init (#25620) Co-authored-by: Theodore Chang <[email protected]> * Initial commit (#25383) * SDK changes for CVM for api-version 2021-11-01 (#25645) * sdk changes for CVM * save changes for securityType and diskSecurityprofile Add PMK scenario * Added recorded file * DedicatedHost Reboot Feature SDK (#25258) * ran autorest on azure-rest-api-specs after adding dhreboot to compute.json * ran autorest again, since i made some swagger changes * created test * renamed reboot to restart * updated swagger, and ran the generate command again to update the sdk * restart test passing. Added recorded test as well * rebuilt sdk with async=true, removed unnecessary line in test, and reran test after change * Adding the new paramaters zone/placementGroupId to ForceRecoveryServiceFabricPlatformUpdateDomainWalk (#25897) * add filter for List VMSS operations (#25802) * fdsaf * generated change * Adding VMScaleSet Flex Filter Test * Update generate.ps1 * add recording Co-authored-by: LexieXie <[email protected]> Co-authored-by: xielexie <[email protected]> * add customizations * fix errors * regenerated from master * fix customization * fix customization * fix a test * new test recordings * change version name * remove unnecessary variable * update recording test * fix changes Co-authored-by: karthikka4820 <[email protected]> Co-authored-by: frank-pang-msft <[email protected]> Co-authored-by: Chase VanBuskirk <[email protected]> Co-authored-by: Chase Van Buskirk <[email protected]> Co-authored-by: Raktima Das <[email protected]> Co-authored-by: kamusta-msft <[email protected]> Co-authored-by: sukodava <[email protected]> Co-authored-by: ms-saypaul <[email protected]> Co-authored-by: vbhasker-msft <[email protected]> Co-authored-by: avjai <[email protected]> Co-authored-by: LexieXie <[email protected]> Co-authored-by: xielexie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.