-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Batch] DataPlane update v15.3.0 - 2022-01-01 #25874
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Batch
label
Dec 10, 2021
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
4 times, most recently
from
December 15, 2021 20:00
60665ce
to
d751abe
Compare
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
3 times, most recently
from
December 30, 2021 18:27
a3e6a33
to
ca3918b
Compare
paterasMSFT
changed the title
Mipatera batch data 2022 01 01
[Batch] DataPlane update v16.0.0 - 2022-01-01
Dec 30, 2021
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
from
December 30, 2021 19:04
ca3918b
to
24204ee
Compare
seth-barshay
approved these changes
Dec 30, 2021
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
2 times, most recently
from
December 30, 2021 20:46
5d8374e
to
964a44f
Compare
paterasMSFT
requested review from
bgklein,
dpwatrous and
wiboris
as code owners
January 5, 2022 17:23
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
from
January 5, 2022 17:27
964a44f
to
fe1efed
Compare
paterasMSFT
changed the title
[Batch] DataPlane update v16.0.0 - 2022-01-01
[Batch] DataPlane update v15.3.0 - 2022-01-01
Jan 5, 2022
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
from
January 5, 2022 18:08
39cbf71
to
08db022
Compare
jsquire
added
Client
This issue points to a problem in the data-plane of the library.
and removed
Data Plane
labels
Jan 7, 2022
dpwatrous
reviewed
Jan 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall - added just a few comments.
sdk/batch/Microsoft.Azure.Batch/Tools/ObjectModelCodeGenerator/Spec/HttpHeader.json
Outdated
Show resolved
Hide resolved
sdk/batch/Microsoft.Azure.Batch/Tools/ObjectModelCodeGenerator/Spec/HttpHeader.json
Outdated
Show resolved
Hide resolved
Added protocol properties Updated changelog. Updated custom constructor. Reverted constructor change Updated version Reverted version Made HttpHeader properties settable
Fixed version in changelog minor Added date to change log Removed links Switched version Updated date
Assert comment Changed assert type
paterasMSFT
force-pushed
the
mipatera-batch-data-2022-01-01
branch
from
January 7, 2022 19:01
08db022
to
eeafab3
Compare
dpwatrous
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
Swagger Pull Request
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.