Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch] DataPlane update v15.3.0 - 2022-01-01 #25874

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

paterasMSFT
Copy link
Contributor

@paterasMSFT paterasMSFT commented Dec 10, 2021

All SDK Contribution checklist:

Swagger Pull Request

  • Added property uploadHeaders to OutputFileBlobContainerDestination.
    • Allows users to set custom HTTP headers on resource file uploads.
    • Array of type HttpHeader (also being added).
  • Added boolean property allowTaskPreemption to JobSpecification, CloudJob, JobAddParameter, JobPatchParameter, JobUpdateParameter
    • Mark Tasks as preemptible for higher priority Tasks (requires Comms-Enabled or Single Tenant Pool).
  • Replaced comment (title, description, etc.) references of "low-priority" with "Spot/Low-Priority", to reflect new service behavior.
    • No API change required.
    • Low-Priority Compute Nodes (VMs) will continue to be used for User Subscription pools (and only User Subscription pools), as before.
    • Spot Compute Nodes (VMs) will now be used for Batch Managed (and only Batch Managed pools) pools.

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
    

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added the Batch label Dec 10, 2021
@paterasMSFT paterasMSFT force-pushed the mipatera-batch-data-2022-01-01 branch 4 times, most recently from 60665ce to d751abe Compare December 15, 2021 20:00
@paterasMSFT paterasMSFT force-pushed the mipatera-batch-data-2022-01-01 branch 3 times, most recently from a3e6a33 to ca3918b Compare December 30, 2021 18:27
@paterasMSFT paterasMSFT changed the title Mipatera batch data 2022 01 01 [Batch] DataPlane update v16.0.0 - 2022-01-01 Dec 30, 2021
@paterasMSFT paterasMSFT self-assigned this Dec 30, 2021
@paterasMSFT paterasMSFT added this to the [2022] January milestone Dec 30, 2021
@paterasMSFT paterasMSFT force-pushed the mipatera-batch-data-2022-01-01 branch 2 times, most recently from 5d8374e to 964a44f Compare December 30, 2021 20:46
@paterasMSFT paterasMSFT marked this pull request as ready for review January 5, 2022 17:23
@paterasMSFT paterasMSFT force-pushed the mipatera-batch-data-2022-01-01 branch from 964a44f to fe1efed Compare January 5, 2022 17:27
@paterasMSFT paterasMSFT marked this pull request as draft January 5, 2022 17:29
@paterasMSFT paterasMSFT changed the title [Batch] DataPlane update v16.0.0 - 2022-01-01 [Batch] DataPlane update v15.3.0 - 2022-01-01 Jan 5, 2022
@paterasMSFT paterasMSFT force-pushed the mipatera-batch-data-2022-01-01 branch from 39cbf71 to 08db022 Compare January 5, 2022 18:08
@paterasMSFT paterasMSFT marked this pull request as ready for review January 6, 2022 17:26
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. and removed Data Plane labels Jan 7, 2022
Copy link
Member

@dpwatrous dpwatrous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall - added just a few comments.

Added protocol properties

Updated changelog.

Updated custom constructor.

Reverted constructor change

Updated version

Reverted version

Made HttpHeader properties settable
Fixed version in changelog

minor

Added date to change log

Removed links

Switched version

Updated date
Assert comment

Changed assert type
@paterasMSFT paterasMSFT merged commit 186d647 into main Jan 12, 2022
@paterasMSFT paterasMSFT deleted the mipatera-batch-data-2022-01-01 branch January 12, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Batch Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants