Instrument some operations #25924
Closed
Instrument some operations #25924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
archerzz,
ArcturusZhang,
ArthurMa1978,
fengzhou-msft,
m-nash and
Yao725
as code owners
m-nash
requested changes
Dec 14, 2021
| @@ -24,7 +24,8 @@ public async Task CreateOrUpdate() | |||
| var vmName = Recording.GenerateAssetName("testVM-"); | |||
| var nic = await CreateBasicDependenciesOfVirtualMachineAsync(); | |||
| var input = ResourceDataHelper.GetBasicLinuxVirtualMachineData(DefaultLocation, vmName, nic.Id); | |||
| var lro = await collection.CreateOrUpdateAsync(vmName, input); | |||
| var lro = InstrumentOperation(await collection.CreateOrUpdateAsync(vmName, input, false)); | |||
There was a problem hiding this comment.
this shouldn't be needed since we override the global time, need to investigate
ghost
added
the
no-recent-activity
|
Hi @christothes. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Oct 25, 2023
Add 2023-11-01-preview for appplatform (Azure#26231) * Adds base for updating Microsoft.AppPlatform from version preview/2023-09-01-preview to version 2023-11-01-preview * Updates readme * Updates API version in new specs and examples * Fix go readme for asa api (Azure#25897) * Update language specific readme.md for 2023-11-01-preview api version (Azure#25898) * add more build result information in build resource (Azure#25930) Co-authored-by: 刘清仪 <[email protected]> * Add apiTryOutEnabledState for api protal (Azure#25923) * Add swagger for Spring Cloud Gateway response cache (Azure#25924) * Update appplatform.json (Azure#26234) * Update appplatform.json * Update appplatform.json --------- Co-authored-by: Sandy Cai <[email protected]> Co-authored-by: Qingyi Liu <[email protected]> Co-authored-by: 刘清仪 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were causing some test timeouts.