-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SR API updates based on architect feedback #27016
Conversation
JoshLove-msft
commented
Feb 15, 2022
- MessageWithMetadata renamed to BinaryContent
- Encoder/Encode/Decode replaced with Serializer/Serialize/Deserialize - since we don't use "ObjectSerializer" we think this will be enough to differentiate from the abstraction.
API changes have been detected in |
API changes have been detected in |
API changes have been detected in API changes - public class EventData : MessageWithMetadata {
+ public class EventData : BinaryContent { |
sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj
Outdated
Show resolved
Hide resolved
sdk/eventhub/Azure.Messaging.EventHubs/src/Azure.Messaging.EventHubs.csproj
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments, but the APIs look good.
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md
Show resolved
Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md
Outdated
Show resolved
Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md
Outdated
Show resolved
Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md
Outdated
Show resolved
Hide resolved
...hemaRegistry.ApacheAvro/api/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
API changes have been detected in |