Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SR API updates based on architect feedback #27016

Merged
merged 4 commits into from
Feb 18, 2022
Merged

SR API updates based on architect feedback #27016

merged 4 commits into from
Feb 18, 2022

Conversation

JoshLove-msft
Copy link
Member

  • MessageWithMetadata renamed to BinaryContent
  • Encoder/Encode/Decode replaced with Serializer/Serialize/Deserialize - since we don't use "ObjectSerializer" we think this will be enough to differentiate from the abstraction.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core.Experimental. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Messaging.EventHubs. You can review API changes here

API changes

-     public class EventData : MessageWithMetadata {
+     public class EventData : BinaryContent {

tg-msft
tg-msft approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@tg-msft tg-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but the APIs look good.

sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md Show resolved Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md Outdated Show resolved Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md Outdated Show resolved Hide resolved
sdk/schemaregistry/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro/README.md Outdated Show resolved Hide resolved
...hemaRegistry.ApacheAvro/api/Microsoft.Azure.Data.SchemaRegistry.ApacheAvro.netstandard2.0.cs Outdated Show resolved Hide resolved
@azure-sdk
Copy link
Collaborator

API changes have been detected in Microsoft.Azure.Data.SchemaRegistry.ApacheAvro. You can review API changes here

@JoshLove-msft JoshLove-msft merged commit d56e4a6 into Azure:main Feb 18, 2022
This was referenced Mar 10, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsquire jsquire jsquire approved these changes

@tg-msft tg-msft tg-msft approved these changes

@christothes christothes christothes approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@serkantkaraca serkantkaraca Awaiting requested review from serkantkaraca

@annelo-msft annelo-msft Awaiting requested review from annelo-msft

@conniey conniey Awaiting requested review from conniey

@swathipil swathipil Awaiting requested review from swathipil

@deyaaeldeen deyaaeldeen Awaiting requested review from deyaaeldeen

Assignees
No one assigned
Labels
Azure.Core Event Hubs Schema Registry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JoshLove-msft @azure-sdk @jsquire @tg-msft @christothes