-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Synchronize OperationInternal calls #28375
Synchronize OperationInternal calls #28375
Conversation
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
API change check for API changes are not detected in this pull request for |
sdk/textanalytics/Azure.AI.TextAnalytics/src/AnalyzeHealthcareEntitiesOperation.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Talked to @heaths offline, he has no more issues with this PR
* Initial commit * Minimize code duplication * Fix tests * Fix OperationInternal * Use AsyncLockWithValue from Core * Fix operation naming * Address PR comments * Address PR comment * More tests * Fix one test by hand * More fixed test records * More fixed test records * More fixed test records * More fixed test records * Fix test records * Add tests * Added comments * Address CR comments
* Initial commit * Minimize code duplication * Fix tests * Fix OperationInternal * Use AsyncLockWithValue from Core * Fix operation naming * Address PR comments * Address PR comment * More tests * Fix one test by hand * More fixed test records * More fixed test records * More fixed test records * More fixed test records * Fix test records * Add tests * Added comments * Address CR comments
Changes
OperationInternal
/OperationInternal<T>
so that only one call ofUpdateStatusAsync
andWaitForCompletionAsync
can be executed concurrently. AfterOperationInternal
/OperationInternal<T>
is set in its final state, no more call to the service is made.Implementation is updated based on the discussion in #27639