Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing /sdk/<dir> rules #33597

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add missing /sdk/<dir> rules #33597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,24 @@
#########

# Catch all
/sdk/ @pallavit @jsquire
/sdk/ @pallavit @jsquire

# Rules for directories that fell under catch-all as of 1/19/2023
/sdk/agrifood/ @pallavit @jsquire
# Note there are some sub-rules for this directory, defined below
/sdk/applicationinsights/ @pallavit @jsquire
# Note there are some sub-rules for this directory, defined below
/sdk/cognitiveservices/ @pallavit @jsquire
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things with sub-rules will supersede this, right? For example, I won't be pinged every time there's something from Text Analytics or Form Recognizer that comes through?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these are a set of directories that currently don't have owners and were covered by the /sdk/ pattern before. We should find the correct owners for these paths.

To answer your question exactly any patterns further down would override these but currently there aren't any for these paths.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not concerned with the paths themselves, but the sub-rules with owners below. For my example:

/sdk/cognitiveservices/textanalytics @someone @another

I just want to be sure that would override the top-level rule.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those would definitely override these rules however there currently isn't an /sdk/cognitiveservices/ rule so things like /sdk/cognitiveservices/ci.yml would match against this pattern and that is the path used for pipeline notifications. So we should try to add the correct owners for that so they get notified of pipeline failures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the guidance if we have multiple partners in the same directory? Do we separate the ci pipelines? Do the service team work with the engsys team to separate them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on the teams. If we have multiple teams that we should consider the following:

  • Should they be in the same service directory?
  • Can they all be owners of a shared pipeline for the service directory if they should be together?
  • If they should be in the same service directory but don't want to share ownership then we would need to split up the pipelines further perhaps to the package level. I would say this is the last resort, but it is possible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a lot of these directories we only have track1 SDKs with minimal to 0 activity. So, I am not sure we have clear answers to these questions.

Also, last I heard we were trying to use a central db to keep ownerships current - is that still the plan? Is it happening along with these updates?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we are planning to try and move to a central db that would sync owners but we are still a long way from getting that all figured out.

/sdk/entra/ @pallavit @jsquire
/sdk/graphrbac/ @pallavit @jsquire
/sdk/machinelearningservices/ @pallavit @jsquire
/sdk/maps/ @pallavit @jsquire
# Note there are some sub-rules for this directory, defined below
/sdk/operationalinsights/ @pallavit @jsquire
/sdk/purview/ @pallavit @jsquire
# Note there are some sub-rules for this directory, defined below
/sdk/quantum/ @pallavit @jsquire
/sdk/remoterendering/ @pallavit @jsquire

# ######## Core Libraries ########

Expand Down