Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format

[konrad-jamrozik]

Where applicable, update Windows pools used to azsdk-pool-mms-win-2022-general and rename vmImage to the windows-20xx format.

This discussion explains why we chose given vmImage format:

Mike Harder: 1ES Hosted Pool image name changes
posted in Azure SDK / Engineering System 🛠️ at Wednesday, February 15, 2023 12:10 PM

For further context, please see:

• Transition Windows and Ubuntu agent pools to consume 2022-Compliant images azure-sdk-tools#3407

[azure-sdk]

API change check

API changes are not detected in this pull request.

[konrad-jamrozik]

@benbp @mikeharder do you think that perhaps this line also need an update?

        "AZURE_TEST_AGENT": "WINDOWS_2019_NETCORE31"

I think this PR might have forgot to update it:

• Migrate from Testing from to testing to #33322

I am thinking: if CI passes, merge now without touching this, worry later :)

[mikeharder]

I have no idea how AZURE_TEST_AGENT is used, but yeah I'd update the OS and net versions to match reality.

[benbp]

IIRC this was a workaround I and ACS came up with due to restrictions with registered phone numbers being used in live tests (1:1 limit), and being able to dynamically look up which phone number needed to be used from the keyvault secret.

FYI @danielortega-msft we may need to think about how to keep this variable updated, as if we rev the version here it won't be able to find the secret.

[konrad-jamrozik]

@benbp @mikeharder for now I am going to merge this PR. If anybody has an idea if/how to update this string, I am happy to make another PR doing that.