Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update based on latest swagger #34197

Merged
merged 2 commits into from
Feb 16, 2023
Merged

update based on latest swagger #34197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64e628d
update based on latest swagger
richardcho-msft Feb 15, 2023
e889519
api changes
richardcho-msft Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/communication/Azure.Communication.CallAutomation/src/CallAutomationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ private CreateCallRequestInternal CreateCallRequest(CreateCallOptions options)
? null
: new PhoneNumberIdentifierModel(options?.CallInvite?.SourceCallerIdNumber?.PhoneNumber),
SourceDisplayName = options?.CallInvite?.SourceDisplayName,
SourceIdentity = CommunicationIdentifierSerializer.Serialize(Source),
SourceIdentity = Source == null ? null : CommunicationIdentifierSerializer.Serialize(Source),
};
// Add custom cognitive service domain name
if (options.AzureCognitiveServicesEndpointUrl != null)
Expand Down Expand Up @@ -704,7 +704,7 @@ public virtual CallConnection GetCallConnection(string callConnectionId)
scope.Start();
try
{
return new CallConnection(callConnectionId, CallConnectionRestClient, CallMediaRestClient, _clientDiagnostics, EventProcessor, Source);
return new CallConnection(callConnectionId, CallConnectionRestClient, CallMediaRestClient, _clientDiagnostics, EventProcessor);
}
catch (Exception ex)
{
Expand Down
7 changes: 2 additions & 5 deletions sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,21 +20,19 @@ public class CallConnection
internal CallConnectionRestClient RestClient { get; }
internal CallMediaRestClient CallMediaRestClient { get; }
internal EventProcessor EventProcessor { get; }
internal CommunicationUserIdentifier Source { get; }

/// <summary>
/// The call connection id.
/// </summary>
public virtual string CallConnectionId { get; internal set; }

internal CallConnection(string callConnectionId, CallConnectionRestClient callConnectionRestClient, CallMediaRestClient callCallMediaRestClient, ClientDiagnostics clientDiagnostics, EventProcessor eventProcessor, CommunicationUserIdentifier source = null)
internal CallConnection(string callConnectionId, CallConnectionRestClient callConnectionRestClient, CallMediaRestClient callCallMediaRestClient, ClientDiagnostics clientDiagnostics, EventProcessor eventProcessor)
{
CallConnectionId = callConnectionId;
RestClient = callConnectionRestClient;
CallMediaRestClient = callCallMediaRestClient;
_clientDiagnostics = clientDiagnostics;
EventProcessor = eventProcessor;
Source = source;
}

/// <summary>Initializes a new instance of <see cref="CallConnection"/> for mocking.</summary>
Expand Down Expand Up @@ -416,7 +414,7 @@ public virtual Response<AddParticipantResult> AddParticipant(AddParticipantOptio
}
}

private AddParticipantRequestInternal CreateAddParticipantRequest(AddParticipantOptions options)
private static AddParticipantRequestInternal CreateAddParticipantRequest(AddParticipantOptions options)
{
// validate ParticipantToAdd is not null
Argument.AssertNotNull(options.ParticipantToAdd, nameof(options.ParticipantToAdd));
Expand All @@ -427,7 +425,6 @@ private AddParticipantRequestInternal CreateAddParticipantRequest(AddParticipant
? null
: new PhoneNumberIdentifierModel(options.ParticipantToAdd.SourceCallerIdNumber.PhoneNumber),
SourceDisplayName = options.ParticipantToAdd.SourceDisplayName,
SourceIdentity = Source == null ? null : CommunicationIdentifierSerializer.Serialize(Source),
OperationContext = options.OperationContext == default ? Guid.NewGuid().ToString() : options.OperationContext
};

Expand Down
5 changes: 0 additions & 5 deletions ...cation.CallAutomation/src/Generated/Models/AddParticipantRequestInternal.Serialization.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions .../Azure.Communication.CallAutomation/src/Generated/Models/AddParticipantRequestInternal.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion sdk/communication/Azure.Communication.CallAutomation/src/autorest.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ tag: package-2023-01-15-preview
model-namespace: false

require:
- https://github.com/williamzhao87/azure-rest-api-specs/blob/cb2cd38aa4a7258e59a912edbb21a21468fb9c6f/specification/communication/data-plane/CallAutomation/readme.md
- https://github.com/williamzhao87/azure-rest-api-specs/blob/0d0cd5af40aa17af76ce0307ac5512351c38e3bc/specification/communication/data-plane/CallAutomation/readme.md
title: Azure Communication Services

generation1-convenience-client: true
Expand Down