Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates #34281

Merged
merged 1 commit into from
Feb 17, 2023
Merged

updates #34281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/communication/Azure.Communication.CallAutomation/src/CallAutomationClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ public virtual Response<AnswerCallResult> AnswerCall(AnswerCallOptions options,
}
}

private static AnswerCallRequestInternal CreateAnswerCallRequest(AnswerCallOptions options)
private AnswerCallRequestInternal CreateAnswerCallRequest(AnswerCallOptions options)
{
// validate callbackUri
if (!IsValidHttpsUri(options.CallbackUri))
Expand All @@ -236,6 +236,7 @@ private static AnswerCallRequestInternal CreateAnswerCallRequest(AnswerCallOptio
request.AzureCognitiveServicesEndpointUrl = options.AzureCognitiveServicesEndpointUrl.AbsoluteUri;
}
request.MediaStreamingConfiguration = CreateMediaStreamingOptionsInternal(options.MediaStreamingOptions);
request.AnsweredByIdentifier = Source == null ? null : CommunicationIdentifierSerializer.Serialize(Source);

return request;
}
Expand Down
4 changes: 2 additions & 2 deletions sdk/communication/Azure.Communication.CallAutomation/src/CallConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ private static TransferToParticipantRequestInternal CreateTransferToParticipantR

foreach (var voipHeader in options.CallInvite.VoipHeaders)
{
request.CustomContext.SipHeaders.Add(voipHeader.Key, voipHeader.Value);
request.CustomContext.VoipHeaders.Add(voipHeader.Key, voipHeader.Value);
}

if (options.OperationContext != null && options.OperationContext.Length > CallAutomationConstants.InputValidation.StringMaxLength)
Expand Down Expand Up @@ -450,7 +450,7 @@ private static AddParticipantRequestInternal CreateAddParticipantRequest(AddPart

foreach (var voipHeader in options.ParticipantToAdd.VoipHeaders)
{
request.CustomContext.SipHeaders.Add(voipHeader.Key, voipHeader.Value);
request.CustomContext.VoipHeaders.Add(voipHeader.Key, voipHeader.Value);
}

return request;
Expand Down
2 changes: 1 addition & 1 deletion ...unication/Azure.Communication.CallAutomation/tests/CallConnections/CallConnectionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ private CallConnection CreateMockCallConnection(int responseCode, string? respon
new object?[]
{
new CallInvite(new CommunicationUserIdentifier("userId")){
SipHeaders = {{ "key1", "value1" }}}
VoipHeaders = {{ "key1", "value1" }}}
},
};
}
Expand Down