[Storage] [DataMovement] Convert TransferStatus from enum to class #38374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amnguye
requested review from
seanmcc-msft,
jaschrep-msft,
schaabs and
tg-msft
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/storage/Azure.Storage.DataMovement/src/DataTransferStatus.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/Shared/DataTransferInternalState.cs
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/Shared/DataTransferStatusInternal.cs
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/DataTransferStatus.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/Shared/DataTransferInternalState.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/TransferJobInternal.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/ServiceToServiceTransferJob.cs
Outdated
Show resolved
Hide resolved
|
/azp run net - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdk/storage/Azure.Storage.DataMovement/src/DataTransferState.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/DataTransferStatus.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/DataTransferStatus.cs
Outdated
Show resolved
Hide resolved
sdk/storage/Azure.Storage.DataMovement/src/DataTransferStatus.cs
Outdated
Show resolved
Hide resolved
jaschrep-msft
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
It may be good to merge this soon and apply touchups in separate PRs. This one has a pretty wide blast radius in lines changed and makes it hard to review more incremental changes.
I mostly just had nitpicks at this point but the race condition will be important to address.
yaotongms
pushed a commit
to yaotongms/azure-sdk-for-net
that referenced
this pull request
Oct 12, 2023
…zure#38374) * WIP * WIP * WIP * WIP * WIP - tests updated * Finished fixing tests with changes * Cleanup * ExportApi * WIP * Fixes to live tests * PR Comments - part 1 * Export API * PR Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting DataTransferStatus from enum to class.
Some of these changes are a lot more trivial than others (e.g. checking enum State in the TransferStatus). The PR is definitely bigger than it seems.
Some of the checkpointer work may be changed anyways when the schema is updated again.