Entra/Library Updates #38532
Merged
Entra/Library Updates #38532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakimms
requested review from
KrzysztofCwalina,
tg-msft,
pallavit and
jsquire
as code owners
github-actions
bot
added
Community Contribution
|
Thank you for your contribution @hakimms! We will review the pull request and get back to you soon. |
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
hakimms
force-pushed
the
main
branch
2 times, most recently
from
77702cb
to
5457e3d
Compare
jsquire
reviewed
Sep 13, 2023
....WebJobs.Extensions.AuthenticationEvents/src/Common/Exceptions/RequestValidationException.cs
Outdated
Show resolved
Hide resolved
...t.Azure.WebJobs.Extensions.AuthenticationEvents/src/Framework/AuthenticationEventMetadata.cs
Outdated
Show resolved
Hide resolved
hakimms
changed the title
jsquire
previously requested changes
Sep 20, 2023
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...ions.AuthenticationEvents/src/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.csproj
Outdated
Show resolved
Hide resolved
...soft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventResponseHandler.cs
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/Helpers.cs
Outdated
Show resolved
Hide resolved
|
@HarmanDhunna, @hakimms: I'd like to introduce @AlexanderSher, who is going to take over as the primary contact for helping with this review and those for the Entra extension going forward. |
Thank you for all of your assistance and guidance @jsquire. |
Changing access level on AuthEventResponseHandler
…ndencies Removed newtonsoft dependencies and used system.text.json for AuthenticationEvents project
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/Helpers.cs
Outdated
Show resolved
Hide resolved
...ions.AuthenticationEvents/src/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.csproj
Outdated
Show resolved
Hide resolved
sdk/entra/Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents/src/Helpers.cs
Outdated
Show resolved
Hide resolved
...ft.Azure.WebJobs.Extensions.AuthenticationEvents/src/AuthenticationEventResource.Designer.cs
Show resolved
Hide resolved
Updated IsJson boolean method to ValidateJson void
|
Adding examples of how the implementation might get used and implemented. |
Added structure for exception classes
…ions Update class to remove outdated exceptions
AlexanderSher
approved these changes
Nov 9, 2023
HarmanDhunna
dismissed
jsquire’s stale review
Review responsibilities passes on to Alexander Sher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update request validation errors to send back 500s to eSTS and response validation errors to send back 400s. This way, we can identify that 500 errors is eSTS are internal and should be marked as failures whereas 400 errors are customer input errors and should be identified as CallerErrors in eSTS.
Bug 2161532: Treat Only Response Validation Errors as 500
9/12/2023
Merged another PR that made the ODataType property in the request payload required.
Bug 2433238: Require ODataType in the payload
9/19/2023
Merged another PR that added metrics to header. Will be used to track the number of requests and responses for each action. Also changed version semantics to Major.Minor.Patch.PreRelease
Product Backlog Item 2653343: Emit metrics in the Nuget
10/4/2023
Merged another PR that made the errors for JSON payload more descriptive when an invalid character is passed and added newtonsoft check to validate payload is JSON format.
Bug 2433252: Invalid JSON should error better