Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync eng/common directory with azure-sdk-tools for PR 7072 #39128

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Sync eng/common directory with azure-sdk-tools for PR 7072 #39128

merged 1 commit into from
Oct 6, 2023

Commits on Oct 6, 2023

  1. Detect all file diff types for eng/common changes 

    Fixes Azure/azure-sdk-tools#5882

We need to set the difffilter to empty instead of the default of exclude deleted files when we are trying to verify there are no changes under eng/common.

See test PR Azure/azure-sdk-for-python#32348 which demonstrates us not detecting a deleted file under eng/common. I'll use that same test PR to verify this now catches that issue.
    @weshaggard @azure-sdk
    weshaggard authored and azure-sdk committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    3789181 View commit details
    Browse the repository at this point in the history