Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalR extensions] Release v1.12.0 #39668

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Conversation

Y-Sindo
Copy link
Member

@Y-Sindo Y-Sindo commented Nov 1, 2023

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Microsoft.Azure.WebJobs.Extensions.SignalRService

@Y-Sindo Y-Sindo changed the title [SignalR extensions] Release v1.11.2 [SignalR extensions] Release v1.12.0 Nov 8, 2023
@JoshLove-msft JoshLove-msft merged commit c284046 into Azure:main Nov 9, 2023
44 checks passed
@ArcturusZhang
Copy link
Member

@Y-Sindo @JoshLove-msft could you please take a look at this test case?

public void ValidateSecurityTokenFacts(string tokenString, SecurityTokenStatus expectedStatus)

It is failing on main branch as well when I run that on my local machine.
This issue is seen in this PR: #39931
and here is the log: https://dev.azure.com/azure-sdk/29ec6040-b234-4e31-b139-33dc4287b756/_apis/build/builds/3256030/logs/950

@Y-Sindo
Copy link
Member Author

Y-Sindo commented Nov 13, 2023

@ArcturusZhang The test case fails because a hard-coded JWT token expires recently. #39930 Fixed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants