Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage][DataMovement] Refactor/fix support for CreationPreference #39881

Merged
merged 5 commits into from
Nov 10, 2023
Merged

[Storage][DataMovement] Refactor/fix support for CreationPreference #39881

merged 5 commits into from
Nov 10, 2023

Conversation

jalauzon-msft
Copy link
Member

This change includes a couple of changes to how we handle the CreationPreference option:

  • Update checkpoint file to store StorageResourceCreationPreference instead of just a bool
  • Allow CreationPreference to be overridden on resume. This also meant we needed to add a new Default option to the enum
  • Refactor how we populate options on resume to allow for overriding. (Includes some changes to how I previosuly handled transfer sizes for consistency).

@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Nov 9, 2023
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Storage.DataMovement

amnguye
amnguye approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@amnguye amnguye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the ChangeLog Breaking Changes to include that the values for this enum are changing.

@jalauzon-msft jalauzon-msft merged commit 74848c7 into Azure:main Nov 10, 2023
15 checks passed
@jalauzon-msft jalauzon-msft deleted the refactor-overwrite branch November 10, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amnguye amnguye amnguye approved these changes

@jaschrep-msft jaschrep-msft jaschrep-msft approved these changes

@seanmcc-msft seanmcc-msft Awaiting requested review from seanmcc-msft seanmcc-msft is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs is a code owner

@tg-msft tg-msft Awaiting requested review from tg-msft tg-msft is a code owner

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalauzon-msft @azure-sdk @jaschrep-msft @amnguye