Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for refresh SDKs in bulk to release the extension mocking function. #40128

Merged
merged 5 commits into from
Nov 24, 2023

Conversation

ArthurMa1978
Copy link
Member

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

azure-sdk commented Nov 20, 2023

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.ResourceManager.Network

Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't change the version of Azure.Containers.ContainerRegistry to a GA version without checking with @pallavit and the feature crew for this library regarding whether this is planned.

@ArthurMa1978 ArthurMa1978 dismissed annelo-msft’s stale review November 24, 2023 02:35

Changed the wrong SDK by mistake, reverted it.

@ArthurMa1978 ArthurMa1978 merged commit 6ce3ec9 into main Nov 24, 2023
75 checks passed
@ArthurMa1978 ArthurMa1978 deleted the mgmt-refresh-1 branch November 24, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants