Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to ComputerVision for full coverage #4388

Closed

Commits on May 29, 2018

  1. Add support for binary serialization/deserialization for HttpRecorder

    The HttpRecorder did not correctly play back binary content.  The propsed fix is to introduce
    new fields in `RecordEntry` named `IsRequestBodyBinary`/`IsResponseBodyBinary`, and use base64
    encoding/decoding when the payload is deemed to be binary.  Currently the test for binary-ness
    is a simple MIME type regex match.
    
    Note that this PR includes tests to confirm the new behavior.  It will failed to build without
    hacking around the fact that the test code depends on the NuGet-installed Microsoft.Azure.Test.HttpRecorder.dll.
    If it is preferable to split the PR so you can update NuGet first without the tests failing, please
    let me know.
    cthrash committed May 29, 2018
    Configuration menu
    Copy the full SHA
    3423244 View commit details
    Browse the repository at this point in the history
  2. ComputerVision test images

    Test images for forthcoming tests.  Checking in first so they can be reference via URL via githubusercontent.
    cthrash committed May 29, 2018
    Configuration menu
    Copy the full SHA
    b05009d View commit details
    Browse the repository at this point in the history
  3. ComputerVision SDK update

    Generated from [PR](Azure/azure-rest-api-specs#3145).
    cthrash committed May 29, 2018
    Configuration menu
    Copy the full SHA
    624268b View commit details
    Browse the repository at this point in the history
  4. ComputerVision tests

    Tests covering all the API methods.
    cthrash committed May 29, 2018
    Configuration menu
    Copy the full SHA
    53ac5f3 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2018

  1. Revert back to old HttpRecorder

    Go back to the old HttpRecorder for now.  Thumbnail tests are commented out until
    it is fixed.
    cthrash committed May 30, 2018
    Configuration menu
    Copy the full SHA
    bc9d651 View commit details
    Browse the repository at this point in the history
  2. Bump version to 1.0.3

    cthrash committed May 30, 2018
    Configuration menu
    Copy the full SHA
    80eec88 View commit details
    Browse the repository at this point in the history