Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CognitiveServices.ComputerVision tests for full coverage #4390

Merged
merged 2 commits into from
Jun 7, 2018
Merged

Add CognitiveServices.ComputerVision tests for full coverage #4390

merged 2 commits into from
Jun 7, 2018

Conversation

cthrash
Copy link
Contributor

@cthrash cthrash commented May 30, 2018

A number of bugs were discovered in the Swagger, and were fixed in this PR.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

dsgouda
dsgouda reviewed May 31, 2018
View reviewed changes
src/SDKs/_metadata/cognitiveservices_data-plane_ComputerVision.txt Outdated
GitHub user: Azure
Branch: current
Commit: cb9c18b988dd67894653a34dc55b7978403b120a
GitHub user: cthrash
Copy link
Contributor

@dsgouda dsgouda May 31, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please generate code from the Azure master branch when the spec PR is merged

dsgouda
dsgouda suggested changes May 31, 2018
View reviewed changes
...on/ComputerVision.Tests/Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests.csproj
@@ -3,7 +3,7 @@
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests</AssemblyName>
<VersionPrefix>1.0.2-preview</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test project is never published, we recommend setting the version to 1.0.0 and never change it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

...ComputerVision/ComputerVision/Microsoft.Azure.CognitiveServices.Vision.ComputerVision.csproj Outdated
@@ -6,7 +6,7 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.ComputerVision</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services ComputerVision APIs.</Description>
<VersionPrefix>1.0.2-preview</VersionPrefix>
<VersionPrefix>1.0.3</VersionPrefix>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.ComputerVision</AssemblyName>
<PackageTags>Microsoft Cognitive Services;Cognitive Services;Cognitive Services SDK;REST HTTP client;Computer Vision;Computer Vision API;Computer Vision SDK;Vision;netcore451511</PackageTags>
<PackageReleaseNotes>This is a preview release of the Cognitive Services Computer Vision SDK.</PackageReleaseNotes>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PackageReleaseNotes

@dsgouda
Copy link
Contributor

dsgouda commented Jun 4, 2018

Also, please rebase the commits to a single commit and update the PR

@cthrash
Add CognitiveServices.ComputerVision tests for full coverage
ca5fdde 
* New SDK generated based on updated Swagger
* New images added for test
* New tests added for full coverage
* Bump version to 1.0.3
cthrash
cthrash commented Jun 5, 2018
View reviewed changes
Copy link
Contributor Author

@cthrash cthrash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates made based on comments

...on/ComputerVision.Tests/Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests.csproj
@@ -3,7 +3,7 @@
<PropertyGroup>
<Description>Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests Class Library</Description>
<AssemblyName>Microsoft.Azure.CognitiveServices.Vision.ComputerVision.Tests</AssemblyName>
<VersionPrefix>1.0.2-preview</VersionPrefix>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@cthrash
Copy link
Contributor Author

cthrash commented Jun 7, 2018

bump

dsgouda
dsgouda suggested changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, needs a couple of comments addressed. Apologize for the turnaround

...ComputerVision/ComputerVision/Microsoft.Azure.CognitiveServices.Vision.ComputerVision.csproj Outdated
@@ -6,10 +6,10 @@
<PropertyGroup>
<PackageId>Microsoft.Azure.CognitiveServices.Vision.ComputerVision</PackageId>
<Description>This client library provides access to the Microsoft Cognitive Services ComputerVision APIs.</Description>
<VersionPrefix>1.0.2-preview</VersionPrefix>
<VersionPrefix>1.0.3</VersionPrefix>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm you plan on releasing a stable version here. If yes, versioning should start from 1.1.0
Also, all the projects need an AssemblyInfo.cs file similar to this with appropriate package versions.

@cthrash
Copy link
Contributor Author

cthrash commented Jun 7, 2018

Thanks for the review. Version updated, metadata added.

dsgouda
dsgouda approved these changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda
Copy link
Contributor

dsgouda commented Jun 7, 2018

Will merge on CIs passing

@dsgouda dsgouda merged commit 5ba013f into Azure:psSdkJson6 Jun 7, 2018
@cthrash cthrash deleted the computervision-tests branch June 7, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthrash @dsgouda