Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComputerVision: Update to v2.0 #4469

Merged
merged 1 commit into from
Jun 21, 2018
Merged

ComputerVision: Update to v2.0 #4469

merged 1 commit into from
Jun 21, 2018

Conversation

cthrash
Copy link
Contributor

@cthrash cthrash commented Jun 20, 2018

  • Support for the revised RecognizeText method. Instead of boolean flag for handwriting recognition, a enumerated mode is provided.
  • The scalars for values like confidence, age, etc., are no longer nullable values. If the containing object exists, the value will be present.
  • Hints for image tags are now exposed when examining the result of AnalyzeImage.
  • Return type has changed when you request AnalyzeImage with details of landmarks.

Swagger PRs: #1, #2.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@cthrash
ComputeVision: Update to v2.0
0e8868d 
* Support for the revised RecognizeText method.  Instead of boolean flag for handwriting recognition, a enumerated mode is provided.
* The scalars for values like confidence, age, etc., are no longer nullable values.  If the containing object exists, the value will be present.
* Hints for image tags are now exposed when examining the result of AnalyzeImage.
* Return type has changed when you request AnalyzeImage with details of landmarks.
@cthrash cthrash changed the title ComputeVision: Update to v2.0 ComputerVision: Update to v2.0 Jun 20, 2018
@cthrash
Copy link
Contributor Author

cthrash commented Jun 20, 2018

Additional context for an earlier aborted PR.

dsgouda
dsgouda approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsgouda dsgouda merged commit 741afc4 into Azure:psSdkJson6 Jun 21, 2018
@cthrash cthrash deleted the cthrash/computervision-recotext branch June 21, 2018 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthrash @dsgouda