Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeploymentManager - SDK preview #5649

Merged
merged 15 commits into from
Apr 8, 2019
Merged

DeploymentManager - SDK preview #5649

merged 15 commits into from
Apr 8, 2019

Conversation

deveshguha
Copy link
Contributor

Initial version of Deployment Manager SDK.

dsgouda
dsgouda suggested changes Apr 1, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please regenerate the code using generate.ps1 and commit changes.

src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
@dsgouda dsgouda closed this Apr 1, 2019
@dsgouda dsgouda reopened this Apr 1, 2019
@deveshguha
Copy link
Contributor Author

Incorporated feedback.

@deveshguha
Copy link
Contributor Author

Autogenerated using generate.ps1.
This required a change to readme.txt in rest-api-specs repo to have the right output directory. This change is in the PR Azure/azure-rest-api-specs#5489

dsgouda
dsgouda suggested changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, a couple of minor changes and should be good to go

src/SDKs/DeploymentManager/DeploymentManager.Tests/DeploymentManager.Tests.csproj Outdated Show resolved Hide resolved
src/SDKs/DeploymentManager/AzSdk.RP.props Outdated Show resolved Hide resolved
dsgouda
dsgouda approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

dsgouda
dsgouda suggested changes Apr 3, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec is not merged. Approved in principle. @deveshguha Please regenerate the code once the spec is merged. Also, the .txt file generated is incorrect. Please make sure you delete and commit the one that is generated when you run the generate.ps1 script

@deveshguha
Copy link
Contributor Author

Spec is not merged. Approved in principle. @deveshguha Please regenerate the code once the spec is merged. Also, the .txt file generated is incorrect. Please make sure you delete and commit the one that is generated when you run the generate.ps1 script

Regenerated after the spec was merged.

dsgouda
dsgouda approved these changes Apr 8, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM will merge once CIs pass

@deveshguha
Copy link
Contributor Author

LGTM will merge once CIs pass

Sounds good, thank you!

@dsgouda dsgouda merged commit 149dd1b into Azure:master Apr 8, 2019
@deveshguha deveshguha deleted the deoletim-adm-uts branch April 8, 2019 22:43
mentat9 pushed a commit to mentat9/azure-sdk-for-net that referenced this pull request Jun 10, 2019
@deveshguha @mentat9
DeploymentManager - SDK preview (Azure#5649)
ecbf247 
* Port from -pr repo

* UT framework; ArtifactSource CRUD tests

* Unit Tests

* Enhance unit tests

* Fix for Playback mode

* Update Tests to fetch SAS from storage

* Update TargetFramework

* Update tests, session records

* PR Feedback

* Autogenerate using generate.ps1

* PR Feedback

* Regerate sdk using generate.ps1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deveshguha @dsgouda