-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeploymentManager - SDK preview #5649
Conversation
…nto deoletim-adm-uts
…nto deoletim-adm-uts
…nto deoletim-adm-uts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please regenerate the code using generate.ps1 and commit changes.
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
src/SDKs/DeploymentManager/DeploymentManager.Tests/Management.DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
Incorporated feedback. |
Autogenerated using generate.ps1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, a couple of minor changes and should be good to go
src/SDKs/DeploymentManager/DeploymentManager.Tests/DeploymentManager.Tests.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge once CIs pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec is not merged. Approved in principle. @deveshguha Please regenerate the code once the spec is merged. Also, the .txt file generated is incorrect. Please make sure you delete and commit the one that is generated when you run the generate.ps1 script
Regenerated after the spec was merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge once CIs pass
Sounds good, thank you! |
* Port from -pr repo * UT framework; ArtifactSource CRUD tests * Unit Tests * Enhance unit tests * Fix for Playback mode * Update Tests to fetch SAS from storage * Update TargetFramework * Update tests, session records * PR Feedback * Autogenerate using generate.ps1 * PR Feedback * Regerate sdk using generate.ps1
Initial version of Deployment Manager SDK.