Skip to content

Commit

Permalink
Enable CodeQL for scheduled CI jobs (#28751)
Browse files Browse the repository at this point in the history
* Enable CodeQL for scheduled, daily CI runs only

* No longer need this include since it's in the archetype

* Update eng/pipelines/templates/stages/archetype-sdk-client.yml

Co-authored-by: Wes Haggard <[email protected]>

* Fix Cosmos custom yml
Cosmos has custom pipeline yml separate from the standard way of doing things.  Fixing their stuff too.

* Don't need this.

* Fixing cosmos custom pipeline yml

* fix the extends usage

---------

Co-authored-by: Wes Haggard <[email protected]>
  • Loading branch information
kurtzeborn and weshaggard authored Feb 15, 2023
1 parent 393ea48 commit a61769a
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 12 deletions.
7 changes: 3 additions & 4 deletions eng/pipelines/templates/jobs/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,9 @@ jobs:
- job: 'Build'
timeoutInMinutes: 90
variables:
- template: ../variables/globals.yml
Codeql.Enabled: true
Codeql.BuildIdentifier: ${{ parameters.ServiceDirectory }}
Codeql.SkipTaskAutoInjection: false

pool:
name: azsdk-pool-mms-ubuntu-2004-general
Expand Down Expand Up @@ -96,9 +98,6 @@ jobs:

timeoutInMinutes: ${{ parameters.TestTimeoutInMinutes }}

variables:
- template: ../variables/globals.yml

dependsOn:
- 'Build'

Expand Down
3 changes: 3 additions & 0 deletions eng/pipelines/templates/stages/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ parameters:
type: boolean
default: false

variables:
- template: /eng/pipelines/templates/variables/globals.yml

stages:
- stage: Build
jobs:
Expand Down
16 changes: 8 additions & 8 deletions eng/pipelines/templates/stages/cosmos-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,14 @@ parameters:
type: boolean
default: false

stages:
- template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
# Skip emulator tests in the CI run
TestMarkArgument: not cosmosEmulator
InjectedPackages: ${{parameters.InjectedPackages}}
Artifacts: ${{parameters.Artifacts}}
extends:
template: /eng/pipelines/templates/stages/archetype-sdk-client.yml
parameters:
ServiceDirectory: ${{ parameters.ServiceDirectory }}
# Skip emulator tests in the CI run
TestMarkArgument: not cosmosEmulator
InjectedPackages: ${{parameters.InjectedPackages}}
Artifacts: ${{parameters.Artifacts}}

# - stage: Test_Emulator
# dependsOn: []
Expand Down
2 changes: 2 additions & 0 deletions eng/pipelines/templates/variables/globals.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,5 @@ variables:
Package.EnableSBOMSigning: true
# this will be disabled until issue#24299 is addressed.
DisableDockerDetector: true
# Disable CodeQL injections except for where we specifically enable it
Codeql.SkipTaskAutoInjection: true

0 comments on commit a61769a

Please sign in to comment.