Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise administration models #13575

Closed
1 of 4 tasks
chlowell opened this issue Sep 4, 2020 · 1 comment
Closed
1 of 4 tasks

Revise administration models #13575

chlowell opened this issue Sep 4, 2020 · 1 comment
Assignees
@mccoyp
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] June

Comments

@chlowell
Copy link
Member

chlowell commented Sep 4, 2020 •
edited
Loading

Decisions to make and implement:

  • Prefer properties (KeyVaultRoleAssignment) or attributes (_Operation)?
    • properties have the benefit of easy immutability
  • How to expose _Operation.error?
    • it matches the OData 4 error format, so we could raise it as ODataV4Error
  • Remove SelectiveKeyRestoreOperation? (it's identical in all but name to RestoreOperation)
    • we decided to keep this as future-proofing
  • _Operation.start_time and .end_time should be datetime
@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. KeyVault labels Sep 4, 2020
@chlowell chlowell added this to the [2020] October milestone Sep 4, 2020
@chlowell chlowell mentioned this issue Sep 4, 2020
Merged
@mccoyp mccoyp modified the milestones: [2021] February, [2021] March Feb 8, 2021
@mccoyp mccoyp modified the milestones: [2021] March, [2021] April Mar 6, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 26, 2021
CodeGen from PR 13575 in Azure/azure-rest-api-specs
d612d24 
frontdoor readme t2 config (Azure#13575)

* wrong opr

* delete unexpected modification

* frontdoor readme t2 config

* readme.python version del

* frontdoor clear-output-folder del

* forntdoor readme.pythong package-version add
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Mar 26, 2021
CodeGen from PR 13575 in Azure/azure-rest-api-specs
2b75c37 
frontdoor readme t2 config (Azure#13575)

* wrong opr

* delete unexpected modification

* frontdoor readme t2 config

* readme.python version del

* frontdoor clear-output-folder del

* forntdoor readme.pythong package-version add
@mccoyp mccoyp modified the milestones: [2021] April, [2021] May Mar 29, 2021
00Kai0 pushed a commit that referenced this issue Mar 30, 2021
@msyyc @RAY-316
[AutoRelease] t2-frontdoor-2021-03-26-19435(wave4) (#17595)
a46589f 
* CodeGen from PR 13575 in Azure/azure-rest-api-specs
frontdoor readme t2 config (#13575)

* wrong opr

* delete unexpected modification

* frontdoor readme t2 config

* readme.python version del

* frontdoor clear-output-folder del

* forntdoor readme.pythong package-version add

* version,CHANGELOG

* frontdoor auto release

* -GA space add

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed <[email protected]>
@mccoyp mccoyp modified the milestones: [2021] May, [2021] June May 6, 2021
@mccoyp mccoyp mentioned this issue Jun 2, 2021
Closed
@mccoyp
Copy link
Member

mccoyp commented Jun 9, 2021 •
edited
Loading

These changes are outdated due to new feedback -- new model alignment is tracked by #19123.

@mccoyp mccoyp closed this as completed Jun 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[Key Vault] Revise administration models mccoyp/azure-sdk-for-python
2 participants
@chlowell @mccoyp