Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Communication SMS Readme issues #15841

Closed
v-xuto opened this issue Dec 17, 2020 · 1 comment
Closed

Communication SMS Readme issues #15841

v-xuto opened this issue Dec 17, 2020 · 1 comment
Assignees
@jbeauregardb
Labels
Client This issue points to a problem in the data-plane of the library. Communication Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass

Comments

@v-xuto
Copy link
Member

v-xuto commented Dec 17, 2020

Section Link:
image

Suggestion:
Add Source code| Package (Pypi)| API reference documentation | Product documentation
As shown in the figure below about app configuration:
image
2.
Section Link:
image

Reason:
Name 'SmsClient' is not defined.

Suggestion:
Add:
from azure.communication.sms import SmsClient
3.
Section link:
image

Reason:
Name 'PhoneNumber' and 'SendSmsOptions' is not defined.

Suggestion:
Add:
from azure.communication.sms import SendSmsOptions, PhoneNumber
4.
Section link:
image

Suggestion:
Add Hyperlink for "[azure_core]":
[azure_core]: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/core/azure-core/README.md

@jongio for notification.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 17, 2020
@tzhanl tzhanl added Client This issue points to a problem in the data-plane of the library. Communication Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass labels Dec 17, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 17, 2020
@jbeauregardb jbeauregardb self-assigned this Feb 19, 2021
@jbeauregardb
Copy link
Contributor

@v-xuto I'm on call this week and I'm working on these issues you submitted. This is a PR that addresses your issues :)
#16825

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Sep 22, 2021
@nilgupta6
CodeGen from PR 15841 in Azure/azure-rest-api-specs
15d2367 
Azure Site Recovery: New version/2021 08 01 (Azure#15841)

* New Version 2021-08-01

* New Version 2021-08-01

* Adding new storage account input

* Adding default value for automationAccount authentication type

* Fixing indenation

* removing new storage account changes

Co-authored-by: Nilesh Gupta <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbeauregardb jbeauregardb

Labels
Client This issue points to a problem in the data-plane of the library. Communication Docs needs-team-triage Workflow: This issue needs the team to triage. test-manual-pass
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tzhanl @v-xuto @jbeauregardb