Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Key Vault] Redact vault names completely in test recordings #17228

Closed
mccoyp opened this issue Mar 10, 2021 · 1 comment
Closed

[Key Vault] Redact vault names completely in test recordings #17228

mccoyp opened this issue Mar 10, 2021 · 1 comment
Assignees
@mccoyp
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Milestone
[2022] April

Comments

@mccoyp
Copy link
Member

mccoyp commented Mar 10, 2021 •
edited
Loading

Context: since starting to use the PowerShellPreparer in Key Vault tests, test recordings contain real vault names in the "url" field of service responses (example here). This only seems to be the case for async tests.

For reference, Form Recognizer handles responses like this to clean up recordings.
@mccoyp mccoyp added KeyVault Client This issue points to a problem in the data-plane of the library. test enhancement labels Mar 10, 2021
@mccoyp mccoyp added this to the [2021] May milestone Mar 10, 2021
@mccoyp mccoyp self-assigned this Mar 10, 2021
@mccoyp mccoyp modified the milestones: [2021] May, Backlog Apr 16, 2021
@mccoyp mccoyp modified the milestones: Backlog, [2022] February Dec 17, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 14, 2022
CodeGen from PR 17228 in Azure/azure-rest-api-specs
be3d108 
Fix swagger correctness: secrets were wrongfully marked as write-only (Azure#17228)

* allow accessKeys to be readable

* add x-ms-identifiers

* remove x-ms-identifier
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 14, 2022
CodeGen from PR 17228 in Azure/azure-rest-api-specs
00459cb 
Fix swagger correctness: secrets were wrongfully marked as write-only (Azure#17228)

* allow accessKeys to be readable

* add x-ms-identifiers

* remove x-ms-identifier
@mccoyp mccoyp modified the milestones: [2022] February, [2022] March Feb 15, 2022
@mccoyp mccoyp modified the milestones: [2022] March, [2022] April Mar 1, 2022
@mccoyp
Copy link
Member Author

mccoyp commented Mar 30, 2022

Update: test proxy recordings successfully redact vault names where the vcrpy-based system didn't before. This can be considered an implicit part of #21051 -- closing as a result.

@mccoyp mccoyp closed this as completed Mar 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mccoyp mccoyp

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault test-enhancement
Projects
None yet
Milestone
[2022] April
Development

No branches or pull requests
2 participants
@lmazuel @mccoyp