Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Add support for AzureNamedKeyCredential #18441

Closed
annatisch opened this issue Apr 29, 2021 · 2 comments · Fixed by #18456
Closed

[Tables] Add support for AzureNamedKeyCredential #18441

annatisch opened this issue Apr 29, 2021 · 2 comments · Fixed by #18456
Assignees
@seankane-msft
Labels
Tables
Milestone
[2021] May

Comments

@annatisch
Copy link
Member

This should be in place of the current dict/str based implementation.
The only supported types for the credential parameter will now be AzureNamedKeyCredential, AzureSasKeyCredential or via connection string (with samples/readme etc updated to match).

The azure-core dependency version will also need to be updated to match.
@annatisch annatisch added this to the [2021] May milestone Apr 29, 2021
@seankane-msft seankane-msft self-assigned this Apr 30, 2021
@seankane-msft
Copy link
Member

@annatisch should this be AzureKeyCredential ?

@annatisch
Copy link
Member Author

No, AzureNamedKeyCredential
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/core/azure-core/azure/core/credentials.py#L117

@seankane-msft seankane-msft mentioned this issue Apr 30, 2021
Merged
@seankane-msft seankane-msft linked a pull request May 3, 2021 that will close this issue
[Tables] Adds support for AzureNamedKeyCredential #18456
Merged
@ghost ghost closed this as completed in #18456 May 5, 2021
ghost pushed a commit that referenced this issue May 5, 2021
@seankane-msft
[Tables] Adds support for AzureNamedKeyCredential (#18456)
4aaa88a 
#18441
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@seankane-msft seankane-msft

Labels
Tables
Projects
None yet
Milestone
[2021] May
Development

Successfully merging a pull request may close this issue.

[Tables] Adds support for AzureNamedKeyCredential seankane-msft/azure-sdk-for-python
2 participants
@annatisch @seankane-msft