Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SKR changes from Arch Board meeting #21380

Closed
heaths opened this issue Oct 22, 2021 · 0 comments
Closed

SKR changes from Arch Board meeting #21380

heaths opened this issue Oct 22, 2021 · 0 comments
Assignees
@YalinLi0312
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] November

Comments

@heaths
Copy link
Member

heaths commented Oct 22, 2021

After discussion with the Key Vault and Managed HSM teams on Secure Key Release, we have arrived at the following changes for SKR models to be done in the SDK (the service will not be renaming in the swagger):

  • KeyReleasePolicy.Data -> KeyReleasePolicy.EncodedPolicy
  • The target parameter in KeyClient.ReleaseKey -> targetAttestationToken

The ReleaseKeyResult.Value property should be left as-is.
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 22, 2021
@heaths heaths added this to the [2021] November milestone Oct 22, 2021
@YalinLi0312 YalinLi0312 self-assigned this Oct 28, 2021
@YalinLi0312 YalinLi0312 mentioned this issue Nov 5, 2021
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Nov 2, 2022
@sri- @jayati-tehri @tadelesh
CodeGen from PR 21380 in Azure/azure-rest-api-specs
8c8058d 
Release cost management microsoft.cost management 2022 10 01 (Azure#21380)

* Adds base for updating Microsoft.CostManagement from version stable/2022-05-01 to version 2022-10-01

* Updates readme

* Updates API version in new specs and examples

* Upgrading Scheduled Actions API to GA (Azure#20964)

* Upgrading Scheduled Actions API to GA

* First commit:- upgrading existing API to GA version

* Upgraded api-version

* Adding Operations API in common-types

* upgrading api-version in Operations example

* referencing common operation def

* removing reference to common Operation as it caused multiple validation
errors

* renaming Operation to CostManagementOperation and referencing Operation from V3 types

* fixing csv

* SavingsPlan GA changes (Azure#20776)

* SavingsPlan GA changes

Fix validation errors

Rebase with shared branch

Correct version in the common-types file

Review comments

Review comments

Refer grain enum in parameter

Correct enum type

Review comments

More improvements

* Fix duplicated model lint diff error

* Use common types v2

* Move to v2 types.json

* Corrected examples

* Sri/release cost management microsoft.cost management 2022 10 01 (Azure#21036)

* First commit - copying cost management and exports API from 2021-10-01

* Upgrading version

* Adding costmanagement.generatedetailedcostreport.json

* fixing validation errors

* fixing validation errors

* fixing validation errors

* reverting parameter order update

* Reverting CostManagementProxyResource and CostManagementResource changes after breaking changes office hours discussion

* ddressing review comments

* Resolving code review comments

* Qualifying Resource and ProxyResource with CostManagement prefix

Please enter the commit message for your changes. Lines starting

* Addressing review comments

* fixing example file names

* fixing linter error

* updated operationResults description

* Reverting breaking changes in exports API

* fixing validation error

* Rebasing with latest

* fixing billingAccountIdParameter definition conflict

* fixing billing profile id parameter conflict

* Addressing code review comment

* fixing model validation errors

* Jatehr/cost management pricesheets (Azure#20958)

* Create costmanagement.pricesheets.json

* Create PricesheetDownload.json

* Create PricesheetDownloadByBillingProfile.json

* Create OperationList.json

* Update readme.md

* Update readme.md

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Delete OperationList.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Update PricesheetDownloadByBillingProfile.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* resolve Go SDK stuttering issue

* Update costmanagement.pricesheets.json

* Update readme.md

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update PricesheetDownload.json

* Update PricesheetDownloadByBillingProfile.json

* Delete BenefitRecommendationsByRecommendationId.json

* Update costmanagement.benefits.json

* Update costmanagement.pricesheets.json

* Update costmanagement.pricesheets.json

* Update common-types.json

* Update costmanagement.pricesheets.json

* Update costmanagement.generatedetailedcostreport.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* Update common-types.json

* resolve Go SDK naming collision

Co-authored-by: Chenjie Shi <[email protected]>

* Update descriptions (Azure#21364)

* Update descriptions

* Fix lint errors

Co-authored-by: srilatha inavolu <[email protected]>
Co-authored-by: Jayati Tehri <[email protected]>
Co-authored-by: Chenjie Shi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@YalinLi0312 YalinLi0312

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] November
Development

No branches or pull requests
2 participants
@heaths @YalinLi0312