Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] azure-identity should use the latest msal-extensions 1.0.0 #23927

Closed
jiasli opened this issue Apr 11, 2022 · 4 comments
Closed

[identity] azure-identity should use the latest msal-extensions 1.0.0 #23927

jiasli opened this issue Apr 11, 2022 · 4 comments
Assignees
@xiangyan99
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.

Comments

@jiasli
Copy link
Member

jiasli commented Apr 11, 2022

Azure Identity has pinned msal-extensions to

azure-sdk-for-python/sdk/identity/azure-identity/setup.py

Line 79 in b8a9473

"msal-extensions~=0.3.0",

This makes it impossible for Azure CLI to use msal-extensions 1.0.0 (https://pypi.org/project/msal-extensions/) which has some improvements like AzureAD/microsoft-authentication-extensions-for-python#108.

Please make azure-identity compatible with msal-extensions 1.0.0. Thanks.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 11, 2022
@jiasli jiasli changed the title [identity] azure-identity should use the latest msal-extensions [identity] azure-identity should use the latest msal-extensions 1.0.0 Apr 11, 2022
@azure-sdk azure-sdk added Azure.Identity Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. labels Apr 11, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 11, 2022
@jiasli jiasli mentioned this issue Apr 11, 2022
Merged
@xiangyan99 xiangyan99 mentioned this issue Apr 11, 2022
Merged
@xiangyan99 xiangyan99 removed the needs-team-triage Workflow: This issue needs the team to triage. label Apr 11, 2022
@mccoyp mccoyp closed this as completed Apr 13, 2022
@jiasli jiasli mentioned this issue Apr 26, 2022
Closed
@sybnex
Copy link

sybnex commented Apr 27, 2022

So when will this be released? The combination of azure cli v2.36.0 and the azure-identity module is not working at the moment!

@xiangyan99
Copy link
Member

@sybnex FYI. it is released and available on pypi.

@tonyskidmore tonyskidmore mentioned this issue Nov 2, 2022
Closed
@jiasli jiasli mentioned this issue Jan 5, 2023
Closed
@geekydonna
Copy link

What is the fix for trying to write python that needs this? My CLi is up-to-date, but I'm running into the same problem when I try to use azure-identity in my code

@mccoyp
Copy link
Member

mccoyp commented Jan 31, 2023

Hi @geekydonna, msal-extensions 1.0.0 is supported starting with azure-identity version 1.10.0. If you're having a conflict, you may need to upgrade your version of azure-identity.

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xiangyan99 xiangyan99

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jiasli @sybnex @xiangyan99 @mccoyp @azure-sdk @geekydonna