Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Auth} Provide GitHub issue links for DPAPI errors #22009

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Apr 11, 2022

Description

We see users constantly creating duplicated issues of

But the root cause for these issues remains unknown.

msal-extensions has made these errors catch-able in AzureAD/microsoft-authentication-extensions-for-python#108, but since azure-identity has pinned dependency msal-extensions~=0.3.0, it is not possible for Azure CLI to use the latest msal-extensions which contains that improvement (Azure/azure-sdk-for-python#23927). the dependency on azure-identity is removed by #22124.

Testing Guide

Raise an OSError at https://github.com/AzureAD/microsoft-authentication-extensions-for-python/blob/1.0.0/msal_extensions/windows.py#L108

        err_code = -2146893813
        raise OSError(None, _err_description.get(err_code, ''), None, err_code)

This will produce an error message like

Decryption failed: [WinError -2146893813] Key not valid for use in specified state.. App developer may consider this guidance: https://github.com/AzureAD/microsoft-authentication-extensions-for-python/wiki/PersistenceDecryptionError
Please report to us via Github: https://github.com/Azure/azure-cli/issues/20231

@jiasli jiasli added the DPAPI data protection API label Apr 11, 2022
@jiasli jiasli added this to the Apr 2022 (2022-04-26) milestone Apr 11, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 11, 2022

Auth

@jiasli
Copy link
Member Author

jiasli commented Apr 20, 2022

Several small blemishes of msal-extensions error messages are refined by AzureAD/microsoft-authentication-extensions-for-python#113.

@jiasli jiasli marked this pull request as ready for review April 20, 2022 14:27
@Azure Azure deleted a comment from azure-pipelines bot Apr 21, 2022
@Azure Azure deleted a comment from azure-pipelines bot Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DPAPI data protection API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants