Implementation for indexers operations #11144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
reviewed
May 1, 2020
| return result.indexers | ||
|
|
||
| @distributed_trace | ||
| def delete_indexer(self, indexer, **kwargs): |
There was a problem hiding this comment.
Why we ask user to give entire indexer? Name is good enough. Not correct?
There was a problem hiding this comment.
And you have ':param name: The name of the indexer to delete.' :)
There was a problem hiding this comment.
indexers is Union[str, Indexer] - name is enough to delete unconditionally - we need the model to use match conditions - have documented it in the docstrings
xiangyan99
reviewed
May 1, 2020
sdk/search/azure-search-documents/azure/search/documents/_service/_indexers_client.py
Show resolved
Hide resolved
rakshith91
commented
May 1, 2020
Comment on lines
150
to
151
| :param name: The name of the indexer to delete. | ||
| :type name: str |
There was a problem hiding this comment.
Suggested change
| :param name: The name of the indexer to delete. | |
| :type name: str | |
| :param indexer: The indexer to delete. | |
| :type name: str or ~search.models.Indexer |
rakshith91
commented
May 1, 2020
| @distributed_trace | ||
| def delete_indexer(self, indexer, **kwargs): | ||
| # type: (Union[str, Indexer], **Any) -> None | ||
| """Deletes an indexer. To use only_if_unchanged, the Indexer model |
There was a problem hiding this comment.
Suggested change
| """Deletes an indexer. To use only_if_unchanged, the Indexer model | |
| """Deletes an indexer. To use access conditions, the Indexer model |
There was a problem hiding this comment.
changed the documentation to match conditions
xiangyan99
previously approved these changes
May 1, 2020
xiangyan99
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10836