[formrecognizer] reduce time for recorded tests runs #11970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
added
Cognitive Services
Client
iscai-msft
previously approved these changes
Jun 12, 2020
| @@ -66,11 +66,13 @@ def __init__(self, endpoint, credential, **kwargs): | |||
| # type: (str, Union[AzureKeyCredential, TokenCredential], Any) -> None | |||
|
|
|||
| authentication_policy = get_authentication_policy(credential) | |||
| polling_interval = kwargs.pop("polling_interval", POLLING_INTERVAL) | |||
There was a problem hiding this comment.
Are we documenting this polling_interval kwarg to the client for users? I think a good idea could be to call it _polling_interval if we're the only people expecting the use it, but I don't feel too strongly about this
There was a problem hiding this comment.
This is an azure-core setting, so hopefully once Xiang documents all the core keywords we'll be able to link to that :)
Edit: this should be available to users
iscai-msft
previously approved these changes
Jun 15, 2020
rakshith91
reviewed
Jun 15, 2020
Comment on lines
383
to
384
| self._endpoint, | ||
| self._credential, |
There was a problem hiding this comment.
minor nit:
Suggested change
| self._endpoint, | |
| self._credential, | |
| endpoint=self._endpoint, | |
| crendential=self._credential, |
rakshith91
reviewed
Jun 15, 2020
rakshith91
previously approved these changes
Jun 15, 2020
kristapratico
dismissed stale reviews from rakshith91 and iscai-msft
via
c60894e
we do have tests, discussed offline |
iscai-msft
approved these changes
Jun 15, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: (21 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
ghost
added
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Dec 15, 2020
add hybridcompute track2 config (Azure#11970)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11932
Reduce the time our recorded tests runs take by setting
polling_interval=0if not running live.Pipeline run times decrease from about 35 mins to 8 mins with this PR.
This PR ended up with a few things:
GlobalClientPreparer- this is so we can create the client for each test in the preparer and set the polling_interval accordingly here instead of passing that keyword into each method in each testget_clientmethod b/c we weren't sharing the pipeline between the clients previously. @rakshith91 - can you look at this part? I remember you doing this work for storage as well.Live test pass: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=422700&view=results